Recognize headless label on EndpointSlices - #2069
Merged
Merged
Conversation
aauren
approved these changes
May 5, 2026
aauren
left a comment
Collaborator
There was a problem hiding this comment.
LGTM @rifelpet! Thanks for the fix!
If @catherinetcai agrees I'll let her merge.
catherinetcai
approved these changes
May 10, 2026
catherinetcai
left a comment
Collaborator
There was a problem hiding this comment.
LGTM - thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
bug
What this PR does / why we need it:
Which issue(s) this PR is related to:
#2006 (comment)
Was AI used during the creation of this PR?
What, if any, amount of integration testing was done with this change in a Kubernetes environment?
I have not done any integration testing. We can discuss possible testing strategies in the PR, including opening a Kops PR to temporarily test a custom kube-router image.
Does this PR introduce a breaking change?
Anything else the reviewer should know that wasn't already covered?