Sitelet https://github.com/box/box-ui-elements/pull/4872/commits/732dcb4a76cc793738d99ceca203e9eb1433263f
Skip to content

fix(item-details): Color file property labels gray #4872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mergify merged 1 commit into from
Sep 29, 2026
Merged

fix(item-details): Color file property labels gray #4872

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix(item-details): Color file property labels gray 
Set file property labels with the Text color textOnLightSecondary.
  • Loading branch information
@jackiejou
jackiejou committed Sep 28, 2026
commit 732dcb4a76cc793738d99ceca203e9eb1433263f
20 changes: 10 additions & 10 deletions src/features/item-details/ItemProperties.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ const ItemProperties = ({
{description || onDescriptionChange ? (
<>
<dt id={descriptionId}>
<Text as="span" variant="bodyDefaultSemibold">
<Text as="span" color="textOnLightSecondary" variant="bodyDefaultSemibold">
<FormattedMessage {...messages.description} />
</Text>
</dt>
Expand All @@ -66,7 +66,7 @@ const ItemProperties = ({
{!!url && (
<>
<dt>
<Text as="span" variant="bodyDefaultSemibold">
<Text as="span" color="textOnLightSecondary" variant="bodyDefaultSemibold">
<FormattedMessage {...messages.url} />
</Text>
</dt>
Expand All @@ -76,7 +76,7 @@ const ItemProperties = ({
{owner ? (
<>
<dt>
<Text as="span" variant="bodyDefaultSemibold">
<Text as="span" color="textOnLightSecondary" variant="bodyDefaultSemibold">
<FormattedMessage {...messages.owner} />
</Text>
</dt>
Expand All @@ -86,7 +86,7 @@ const ItemProperties = ({
{enterpriseOwner ? (
<>
<dt>
<Text as="span" variant="bodyDefaultSemibold">
<Text as="span" color="textOnLightSecondary" variant="bodyDefaultSemibold">
<FormattedMessage {...messages.enterpriseOwner} />
</Text>
</dt>
Expand All @@ -96,7 +96,7 @@ const ItemProperties = ({
{uploader ? (
<>
<dt>
<Text as="span" variant="bodyDefaultSemibold">
<Text as="span" color="textOnLightSecondary" variant="bodyDefaultSemibold">
<FormattedMessage {...messages.uploader} />
</Text>
</dt>
Expand All @@ -106,7 +106,7 @@ const ItemProperties = ({
{createdAt ? (
<>
<dt>
<Text as="span" variant="bodyDefaultSemibold">
<Text as="span" color="textOnLightSecondary" variant="bodyDefaultSemibold">
<FormattedMessage {...messages.created} />
</Text>
</dt>
Expand All @@ -118,7 +118,7 @@ const ItemProperties = ({
{modifiedAt ? (
<>
<dt>
<Text as="span" variant="bodyDefaultSemibold">
<Text as="span" color="textOnLightSecondary" variant="bodyDefaultSemibold">
<FormattedMessage {...messages.modified} />
</Text>
</dt>
Expand All @@ -130,7 +130,7 @@ const ItemProperties = ({
{archivedAt ? (
<>
<dt>
<Text as="span" variant="bodyDefaultSemibold">
<Text as="span" color="textOnLightSecondary" variant="bodyDefaultSemibold">
<FormattedMessage {...messages.archived} />
</Text>
</dt>
Expand All @@ -142,7 +142,7 @@ const ItemProperties = ({
{size ? (
<>
<dt>
<Text as="span" variant="bodyDefaultSemibold">
<Text as="span" color="textOnLightSecondary" variant="bodyDefaultSemibold">
<FormattedMessage {...messages.size} />
</Text>
</dt>
Expand All @@ -157,7 +157,7 @@ const ItemProperties = ({
{trashedAt ? (
<>
<dt>
<Text as="span" variant="bodyDefaultSemibold">
<Text as="span" color="textOnLightSecondary" variant="bodyDefaultSemibold">
<FormattedMessage {...messages.deleted} />
</Text>
</dt>
Expand Down
15 changes: 9 additions & 6 deletions src/features/item-details/ItemProperties.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,6 @@
.item-properties {
margin: 0;

dt {
color: $bdl-gray-80;
}

dd {
margin-bottom: 20px;
line-height: 16px;
Expand All @@ -21,7 +17,11 @@
background-color: transparent;
border-color: transparent;
box-shadow: none;
transition: background-color .2s, border-color .2s, margin-left .2s, padding .2s;
transition:
background-color 0.2s,
border-color 0.2s,
margin-left 0.2s,
padding 0.2s;
Comment thread
jackiejou marked this conversation as resolved.
resize: none;

&:hover {
Expand All @@ -48,7 +48,10 @@
padding: 0;
border: none;
box-shadow: none;
transition: border .2s, height .2s, padding .2s;
transition:
border 0.2s,
height 0.2s,
padding 0.2s;

&:focus {
height: 32px;
Expand Down
4 changes: 2 additions & 2 deletions src/features/item-details/RetentionPolicy.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,15 +27,15 @@ const RetentionPolicy = ({ dispositionTime, openModal, policyType, retentionPoli
return (
<>
<dt>
<Text as="span" variant="bodyDefaultSemibold">
<Text as="span" color="textOnLightSecondary" variant="bodyDefaultSemibold">
<FormattedMessage {...messages.retentionPolicyDescription} />
</Text>
</dt>
<dd>{retentionPolicyDescription}</dd>
{policyType !== 'indefinite' ? (
<>
<dt>
<Text as="span" variant="bodyDefaultSemibold">
<Text as="span" color="textOnLightSecondary" variant="bodyDefaultSemibold">
<FormattedMessage {...messages.retentionPolicyExpiration} />
</Text>
</dt>
Expand Down
Loading