Sitelet https://github.com/box/box-ui-elements/pull/4872
Skip to content

fix(item-details): Color file property labels gray - #4872

Merged
mergify[bot] merged 1 commit into
box:masterfrom
jackiejou:file-property-label-gray
Sep 29, 2026
Merged

fix(item-details): Color file property labels gray#4872
mergify[bot] merged 1 commit into
box:masterfrom
jackiejou:file-property-label-gray

Conversation

@jackiejou

@jackiejou jackiejou commented Sep 28, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Contributor

Summary

  • Set file property labels to textOnLightSecondary

Why

Those labels should be gray. textOnLightSecondary is the Text color for secondary text, bp-gray-65 (#6f6f6f).

Test plan

  • Open Details and confirm Description, Owner, Uploader, Created, Modified, Size, Policy, and the other property labels are gray
  • Confirm the values next to those labels stay the default text color

Summary by CodeRabbit

  • Style
    • Updated item property labels, retention-policy descriptions, and expiration information to use the secondary text color for light backgrounds.
    • Kept existing label text, styling variants, visibility conditions, and retention-policy details unchanged.
    • Preserved the existing textarea and URL input transition behavior.

@jackiejou
jackiejou requested review from a team as code owners September 28, 2026 22:59
@coderabbitai

coderabbitai Bot commented Sep 28, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: f6723a35-ad25-4298-93cc-9c47e4cf3679

📥 Commits

Reviewing files that changed from the base of the PR and between 80720e6 and 732dcb4.

📒 Files selected for processing (3)
  • src/features/item-details/ItemProperties.js
  • src/features/item-details/ItemProperties.scss
  • src/features/item-details/RetentionPolicy.tsx
💤 Files with no reviewable changes (1)
  • src/features/item-details/ItemProperties.scss
🚧 Files skipped from review as they are similar to previous changes (1)
  • src/features/item-details/RetentionPolicy.tsx

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 2 remain after this review.

Walkthrough

Item property and retention policy labels now set their text color to textOnLightSecondary. The stylesheet no longer sets the item property label color. Text variants, conditional rendering, and transition properties and durations remain unchanged.

Changes

Item detail label colors

Layer / File(s) Summary
Set item detail label colors
src/features/item-details/ItemProperties.js, src/features/item-details/RetentionPolicy.tsx, src/features/item-details/ItemProperties.scss		 Item property and retention policy labels set Text color to textOnLightSecondary. The stylesheet removes the dt color rule and reformats textarea and URL input transitions without changing their properties or durations.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Bug fix

Suggested reviewers: greg-in-a-box

Merge Risk: ⚪ Minimal · up to 732dc

The change moves item-detail label coloring to Text callers. The exact shade in the locked dependency remains unconfirmed, but no user-visible regression is established, so no actionable merge-blocking risk is currently supported.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 2…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly identifies the main change: updating item-details file property label colors to gray.
Description check ✅ Passed The description includes a summary, reason, and test plan. It explains the use of textOnLightSecondary and verifies label and value colors.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

A rabbit checks each label’s hue,
And finds the secondary shade comes through.
The dates and owners keep their place,
The transitions keep their pace.
It hops away with notes in tow,
While item details softly glow.

Comment @coderabbitai help to get the list of available commands.

jackiejou
jackiejou commented Sep 28, 2026
View reviewed changes
Comment thread src/features/item-details/ItemProperties.scss
tjuanitas
tjuanitas reviewed Sep 28, 2026
View reviewed changes
Comment thread src/features/item-details/ItemProperties.scss Outdated
@jackiejou
fix(item-details): Color file property labels gray
732dcb4 
Set file property labels with the Text color textOnLightSecondary.
@jackiejou
jackiejou force-pushed the file-property-label-gray branch from 80720e6 to 732dcb4 Compare September 28, 2026 23:16
@mergify mergify Bot added the queued label Sep 29, 2026
@mergify

mergify Bot commented Sep 29, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Merge Queue Status

  • ✅ Entered queue — 2026-09-29 00:25 UTC · Rule: Automatic strict merge · triggered by rule Automatic merge queue
  • ✅ Checks skipped · PR is already up-to-date
  • ✅ Merged — 2026-09-29 00:26 UTC · at d6f014370971191f2f4a1ce39166c8e488d90cc2 · squash

This pull request spent 15 seconds in the queue, including 2 seconds running CI.

Required conditions to merge
  • github-review-approved [🛡 GitHub branch protection]
  • any of [🛡 GitHub branch protection]:
    • check-success = Summary
    • check-neutral = Summary
    • check-skipped = Summary
  • any of [🛡 GitHub branch protection]:
    • check-success = lint_test_build
    • check-neutral = lint_test_build
    • check-skipped = lint_test_build
  • any of [🛡 GitHub branch protection]:
    • check-success = license/cla
    • check-neutral = license/cla
    • check-skipped = license/cla
  • any of [🛡 GitHub branch protection]:
    • check-success = lint_pull_request
    • check-neutral = lint_pull_request
    • check-skipped = lint_pull_request

@mergify
mergify Bot merged commit d6f0143 into box:master Sep 29, 2026
11 of 12 checks passed
@mergify mergify Bot removed the queued label Sep 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tjuanitas tjuanitas tjuanitas approved these changes
@jfox-box jfox-box jfox-box approved these changes

Assignees

No one assigned

Labels

ready-to-merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jackiejou @tjuanitas @jfox-box