Repository navigation
Symbolic Representation of collective size - #1
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref: astra-sim PR343
Previously custom collectives had the message size of each send/recv message hardcoded into the custom collective et, which overrode the message size in the workload chakra ET (undesirable!)
This PR resolves this by replacing the hardcoded message size with a symbolic representation of the message size in the custom collective et. The custom collective et now holds
SEND 1 chunk out of 8 chunksinsead ofSEND 1MB of data. ASTRA-sim's system layer then resolves the message size.We look at the information already included in the xml file to find out 1) how many chunks per message and 2) total number of chunk for collective.