Repository navigation
Symbolic Representation of Collective Size - #343
Draft
jinsun-yoo wants to merge 1 commit into
Draft
jinsun-yoo wants to merge 1 commit into
jinsun-yoo wants to merge 1 commit into
Conversation
jinsun-yoo
force-pushed
the
comm_size
branch
from
November 22, 2025 20:43
3a56e51 to
6a7c26b
Compare
jinsun-yoo
force-pushed
the
comm_size
branch
2 times, most recently
from
November 23, 2025 19:02
365ec85 to
7e42cb2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref: collectiveapi PR 1
Summary
Previously custom collectives had the message size of each send/recv message hardcoded into the custom collective et, which overrode the message size in the workload chakra ET (undesirable!)
This PR resolves this by replacing the hardcoded message size with a symbolic representation of the message size in the custom collective et. The custom collective et now holds
SEND 1 chunk out of 8 chunksinsead ofSEND 1MB of data. The system layer then resolves the message size.DRAFT PR
This is a draft PR. The feature is functional, but some stuff needs to be done: