Repository navigation
fix(db): drop deleted competitors from competitor_aggregates - #560
Merged
Merged
Conversation
Merged
7 of 12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Deleting a competitor stops future tracking runs from scoring it, but the Insights Leaderboard, the provider breakdown and the Competitors comparison kept showing it until the selected date window aged past its last scraped result — the
competitor_aggregatesRPC aggregates the historicalcompetitor_mentionsJSON onprompt_resultsand never checked whether the competitor still exists.New migration
00035_competitor_aggregates_live_only.sqlredefines the function (CREATE OR REPLACE, return type unchanged) with a liveness check in thementions_flatCTE: a mention row is kept only if itscompetitor_idresolves to a livecompetitorsrow of the same brand. Removed competitors drop out of every competitor-side CTE at once, for every date range.EXISTSclause.SECURITY INVOKERkept; grants from 00006 carry over withCREATE OR REPLACE.filteredCTE, and each remaining competitor's rate uses its ownvisible_promptsover the sharedbrand_prompt_count.schema.sqlregenerated viabash supabase/build-schema.sh.Migration will be applied to the hosted database after merge.
Related issue
Closes #538
Type of change
feat— New featurefix— Bug fixchore— Maintenance / dependenciesdocs— Documentation onlyrefactor— Code change that neither fixes a bug nor adds a featuretest— Adding or updating testsHow to test
Checklist
feature/,fix/,chore/,docs/) — see CONTRIBUTING.mdyarn lintpasses (run fromweb/)yarn typecheckpasses (run fromweb/)yarn format:checkpasses (run fromweb/)