Sitelet https://github.com/alloy-rs/examples/pull/204
Skip to content

feat: use signers in provider and demonstrate EthereumWallet - #204

Merged
yash-atreya merged 6 commits into
mainfrom
yash/signer-instead-of-wallet
Apr 2, 2025
Merged

yash-atreya merged 6 commits into
mainfrom
yash/signer-instead-of-wallet

Conversation

@yash-atreya

Copy link
Copy Markdown
Contributor

Motivation

Closes #197
Closes #56

Solution

  • Replace all instances of EthereumWallet being passed to .wallet(..) with directly passing the signer.
  • Demonstrate EthereumWallet in a separate example.

PR Checklist

  • Added Documentation
  • Breaking changes

@zerosnacks zerosnacks left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice dx improvement 👍

@github-project-automation github-project-automation Bot moved this to Reviewed in Alloy Apr 2, 2025

@mattsse mattsse left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, pending @zerosnacks

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is very helpful

@yash-atreya
yash-atreya merged commit 403e884 into main Apr 2, 2025
@github-project-automation github-project-automation Bot moved this from Reviewed to Done in Alloy Apr 2, 2025
@zerosnacks
zerosnacks deleted the yash/signer-instead-of-wallet branch May 8, 2025 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

chore: replace EthereumWallet with just the signer Add example to show multiple signers on same EthereumWallet

3 participants