Sitelet https://github.com/MessagePack-CSharp/MessagePack-CSharp/pull/2300/files
Skip to content

Fix build warning and Windows build break #2300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AArnott merged 2 commits into from
Sep 17, 2026
+11 −4
Merged

Fix build warning and Windows build break #2300

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
912ced7
Validate Windows builds
AArnott Sep 17, 2026
f7a4852
Treat CI build warnings as errors
AArnott Sep 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions .github/workflows/dotnet.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,12 +13,16 @@ on:

jobs:
build-dotnet:
runs-on: ubuntu-latest
strategy:
fail-fast: false
matrix:
os: [ubuntu-latest, windows-latest]
runs-on: ${{ matrix.os }}
timeout-minutes: 15
steps:
- uses: actions/checkout@v4
with:
fetch-depth: 0 # avoid shallow clone so nbgv can do its work.
- uses: ./.github/actions/setup-dotnet
- run: dotnet build -c Release -t:build,pack
- run: dotnet build -c Release -t:build,pack -warnaserror
- run: dotnet test -c Release --no-build
2 changes: 1 addition & 1 deletion tests/MessagePack.SourceGenerator.Tests/Verifiers/CSharpSourceGeneratorVerifier`1+Test.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
// Licensed under the MIT license. See LICENSE file in the project root for full license information.

// Uncomment the following line to write expected files to disk
#define WRITE_EXPECTED
// #define WRITE_EXPECTED

#if WRITE_EXPECTED
#warning WRITE_EXPECTED is fine for local builds, but should not be merged to the main branch.
Expand Down
5 changes: 4 additions & 1 deletion tests/MessagePack.Tests/MessagePackWriterTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,10 @@ public void WriteBinHeader()
public void Write_ByteArray_OldSpec_AvoidsStr8(int length)
{
byte[] value = new byte[length];
Array.Fill(value, (byte)'A');
for (int i = 0; i < value.Length; i++)
{
value[i] = (byte)'A';
}

var sequence = new Sequence<byte>();
var writer = new MessagePackWriter(sequence) { OldSpec = true };
Expand Down
Loading