Sitelet https://github.com/MessagePack-CSharp/MessagePack-CSharp/pull/2300
Skip to content

Fix build warning and Windows build break - #2300

Merged
AArnott merged 2 commits into
masterfrom
fix/windows-build-validation
Sep 17, 2026
Merged

AArnott merged 2 commits into
masterfrom
fix/windows-build-validation

Conversation

@AArnott

@AArnott AArnott commented Sep 17, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • Fixes build break on Windows machines since .NET Framework targeting is only included on Windows.
  • Patch the PR check hole that allowed the Windows build break to slip through.
  • Remove the test file WRITE_EXPECTED C# define that is never supposed to be committed and was generating a build warning.
  • Patch the PR check hole that allowed the compiler warning to slip through.

Validation

  • dotnet build -t:Rebuild
  • dotnet build -c Release -t:build,pack
  • dotnet test -c Release --no-build

AArnott and others added 2 commits September 17, 2026 09:58
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@AArnott
AArnott requested a review from neuecc September 17, 2026 16:05
@AArnott AArnott changed the title Validate Windows builds Fix build warning and Windows build break Sep 17, 2026
@AArnott
AArnott merged commit ab3119e into master Sep 17, 2026
4 checks passed
@AArnott
AArnott deleted the fix/windows-build-validation branch September 17, 2026 16:12
This was referenced Sep 17, 2026
This was referenced Sep 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant