Repository navigation
use correct componentId element on delete button - #475
Merged
Merged
Conversation
MoonTM-GIT
approved these changes
Jan 26, 2024
jasonlessenich
approved these changes
Mar 31, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the delete button does yields a permission error for non-moderators.
This is because the check for the requester ID (the user who is allowed to delete it) is using the wrong component ID.
It seems I didn't properly test #446 (well actually the account I tested it with probably had the registered mod role)
The issue was discovered by @DeveloperCallum.