Sitelet https://github.com/Java-Discord/JavaBot/pull/446
Skip to content

allow deleting responses of own messages/commands with delete button - #446

Merged
jasonlessenich merged 2 commits into
Java-Discord:mainfrom
danthe1st:delete-self-response
Oct 25, 2023
Merged

jasonlessenich merged 2 commits into
Java-Discord:mainfrom
danthe1st:delete-self-response

Conversation

@danthe1st

Copy link
Copy Markdown
Member

Currently, the delete button on component messages like /format-code or automated responses (e.g. closing reminders) can only be deleted by staff members due to the bot checking the message sender (which is the bot) instead of the user who originally requested the action.

This PR adds a user ID to the delete message button in order to allow message deletion by the user who originally requested it/who the message is for.

https://canary.discord.com/channels/648956210850299986/752535909228085348/1155209604909760745

@danthe1st
danthe1st requested a review from a team as a code owner September 25, 2023 12:38

@jasonlessenich jasonlessenich left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How was this left unnoticed 💀 thanks for fixing this

@danthe1st

Copy link
Copy Markdown
Member Author

image

Since requested in the suggestion, the bot now also includes a (now working) delete button in the message link content message.

@Pleezon
Pleezon self-requested a review October 4, 2023 07:23

@Pleezon Pleezon left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jasonlessenich
jasonlessenich merged commit 98e7201 into Java-Discord:main Oct 25, 2023
@danthe1st
danthe1st deleted the delete-self-response branch October 25, 2023 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants