Sitelet https://web.archive.org/web/20201119230420/https://github.com/jsonld-java/jsonld-java/pull/291
Skip to content

/ jsonld-java

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix jarcache guava loading #291

Merged
merged 1 commit into from Jul 9, 2020
Merged

Fix jarcache guava loading #291

merged 1 commit into from Jul 9, 2020

Conversation

@elahrvivaz
Copy link
Contributor

@elahrvivaz elahrvivaz commented Jul 8, 2020

  • Don't minimize guava shading, causes NoClassDefFoundError
@elahrvivaz
Fix jarcache guava loading
Loading status checks…
d310e59 
* Don't minimize guava shading, causes NoClassDefFoundError
@elahrvivaz
Copy link
Contributor Author

@elahrvivaz elahrvivaz commented Jul 8, 2020

With the current shading in 13.0, trying to use the jarcache results in an error. Removing the minimize flag makes it work again.

java.lang.NoClassDefFoundError: com/github/jsonldjava/shaded/com/google/common/util/concurrent/internal/InternalFutureFailureAccess
	at java.lang.ClassLoader.defineClass1(Native Method)
	at java.lang.ClassLoader.defineClass(ClassLoader.java:763)
	at java.security.SecureClassLoader.defineClass(SecureClassLoader.java:142)
	at java.net.URLClassLoader.defineClass(URLClassLoader.java:467)
	at java.net.URLClassLoader.access$100(URLClassLoader.java:73)
	at java.net.URLClassLoader$1.run(URLClassLoader.java:368)
	at java.net.URLClassLoader$1.run(URLClassLoader.java:362)
	at java.security.AccessController.doPrivileged(Native Method)
	at java.net.URLClassLoader.findClass(URLClassLoader.java:361)
	at java.lang.ClassLoader.loadClass(ClassLoader.java:424)
	at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:338)
	at java.lang.ClassLoader.loadClass(ClassLoader.java:357)
	at java.lang.ClassLoader.defineClass1(Native Method)
	at java.lang.ClassLoader.defineClass(ClassLoader.java:763)
	at java.security.SecureClassLoader.defineClass(SecureClassLoader.java:142)
	at java.net.URLClassLoader.defineClass(URLClassLoader.java:467)
	at java.net.URLClassLoader.access$100(URLClassLoader.java:73)
	at java.net.URLClassLoader$1.run(URLClassLoader.java:368)
	at java.net.URLClassLoader$1.run(URLClassLoader.java:362)
	at java.security.AccessController.doPrivileged(Native Method)
	at java.net.URLClassLoader.findClass(URLClassLoader.java:361)
	at java.lang.ClassLoader.loadClass(ClassLoader.java:424)
	at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:338)
	at java.lang.ClassLoader.loadClass(ClassLoader.java:357)
	at java.lang.ClassLoader.defineClass1(Native Method)
	at java.lang.ClassLoader.defineClass(ClassLoader.java:763)
	at java.security.SecureClassLoader.defineClass(SecureClassLoader.java:142)
	at java.net.URLClassLoader.defineClass(URLClassLoader.java:467)
	at java.net.URLClassLoader.access$100(URLClassLoader.java:73)
	at java.net.URLClassLoader$1.run(URLClassLoader.java:368)
	at java.net.URLClassLoader$1.run(URLClassLoader.java:362)
	at java.security.AccessController.doPrivileged(Native Method)
	at java.net.URLClassLoader.findClass(URLClassLoader.java:361)
	at java.lang.ClassLoader.loadClass(ClassLoader.java:424)
	at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:338)
	at java.lang.ClassLoader.loadClass(ClassLoader.java:357)
	at com.github.jsonldjava.shaded.com.google.common.cache.LocalCache$LoadingValueReference.<init>(LocalCache.java:3472)
	at com.github.jsonldjava.shaded.com.google.common.cache.LocalCache$LoadingValueReference.<init>(LocalCache.java:3476)
	at com.github.jsonldjava.shaded.com.google.common.cache.LocalCache$Segment.lockedGetOrLoad(LocalCache.java:2134)
	at com.github.jsonldjava.shaded.com.google.common.cache.LocalCache$Segment.get(LocalCache.java:2045)
	at com.github.jsonldjava.shaded.com.google.common.cache.LocalCache.get(LocalCache.java:3953)
	at com.github.jsonldjava.shaded.com.google.common.cache.LocalCache.getOrLoad(LocalCache.java:3976)
	at com.github.jsonldjava.shaded.com.google.common.cache.LocalCache$LocalLoadingCache.get(LocalCache.java:4960)
	at com.github.jsonldjava.utils.JarCacheStorage.getJarCache(JarCacheStorage.java:241)
@ansell ansell merged commit c867a0a into jsonld-java:master Jul 9, 2020
1 check failed
1 check failed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
@elahrvivaz elahrvivaz deleted the elahrvivaz:guava_maximize branch Jul 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@elahrvivaz @ansell
You can’t perform that action at this time.