Sitelet https://web.archive.org/web/20220323014247/https://github.com/nodejs/node/pull/35545
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add release key for Danielle Adams #35545

Closed

Conversation

danielleadams
Copy link
Member

@danielleadams danielleadams commented Oct 7, 2020 •

Add Danielle Adams's release key.

Checklist

Add Danielle Adams's release key.
@nodejs-github-bot nodejs-github-bot added the doc label Oct 7, 2020
@richardlau richardlau added the notable-change label Oct 7, 2020
Copy link
Member

@BethGriggs BethGriggs left a comment

I can import the key too

Copy link
Member

@MylesBorins MylesBorins left a comment

LGTM

Trott
Trott approved these changes Oct 8, 2020
lpinca
lpinca approved these changes Oct 19, 2020
@lpinca lpinca added the request-ci label Oct 19, 2020
@github-actions github-actions bot removed the request-ci label Oct 19, 2020
@nodejs-github-bot
Copy link
Contributor

@nodejs-github-bot nodejs-github-bot commented Oct 19, 2020

@nodejs-github-bot
Copy link
Contributor

@nodejs-github-bot nodejs-github-bot commented Oct 20, 2020

@richardlau richardlau added the commit-queue label Oct 20, 2020
@github-actions github-actions bot removed the commit-queue label Oct 20, 2020
@github-actions
Copy link

@github-actions github-actions bot commented Oct 20, 2020

Commit Queue failed
- Loading data for nodejs/node/pull/35545
✔  Done loading data for nodejs/node/pull/35545
----------------------------------- PR info ------------------------------------
Title      doc: add release key for Danielle Adams (#35545)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     danielleadams:add-danielleadams-gpg-key -> nodejs:master
Labels     doc, notable-change
Commits    1
 - doc: add release key for Danielle Adams
Committers 1
 - Danielle Adams 
PR-URL: https://github.com/nodejs/node/pull/35545
Reviewed-By: Richard Lau 
Reviewed-By: Beth Griggs 
Reviewed-By: Shelley Vohr 
Reviewed-By: Myles Borins 
Reviewed-By: Rich Trott 
Reviewed-By: Luigi Pinca 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/35545
Reviewed-By: Richard Lau 
Reviewed-By: Beth Griggs 
Reviewed-By: Shelley Vohr 
Reviewed-By: Myles Borins 
Reviewed-By: Rich Trott 
Reviewed-By: Luigi Pinca 
--------------------------------------------------------------------------------
   ✖  Last GitHub CI failed
   ℹ  Doc-only changes
   ℹ  This PR was created on Wed, 07 Oct 2020 18:05:22 GMT
   ✔  Approvals: 6
   ✔  - Richard Lau (@richardlau): https://github.com/nodejs/node/pull/35545#pullrequestreview-504142713
   ✔  - Beth Griggs (@BethGriggs) (TSC): https://github.com/nodejs/node/pull/35545#pullrequestreview-504166059
   ✔  - Shelley Vohr (@codebytere) (TSC): https://github.com/nodejs/node/pull/35545#pullrequestreview-504259102
   ✔  - Myles Borins (@MylesBorins) (TSC): https://github.com/nodejs/node/pull/35545#pullrequestreview-504384484
   ✔  - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/35545#pullrequestreview-504708969
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/35545#pullrequestreview-512089607
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu

Commit Queue action: https://github.com/nodejs/node/actions/runs/317344068

@github-actions github-actions bot added the commit-queue-failed label Oct 20, 2020
@MylesBorins
Copy link
Member

@MylesBorins MylesBorins commented Oct 20, 2020

Landed in 6b6bbfe

MylesBorins added a commit that referenced this issue Oct 20, 2020
Add Danielle Adams's release key.

PR-URL: #35545
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
BethGriggs pushed a commit that referenced this issue Oct 21, 2020
Add Danielle Adams's release key.

PR-URL: #35545
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@BethGriggs BethGriggs mentioned this pull request Oct 21, 2020
BethGriggs pushed a commit that referenced this issue Oct 21, 2020
Notable changes:

- **crypto**: fix regression on randomFillSync (James M Snell)
  (#35723)
  * This fixes issue #35722.
- **doc**: add release key for Danielle Adams (Danielle Adams)
  (#35545)

PR-URL: #35736
BethGriggs pushed a commit that referenced this issue Oct 21, 2020
Notable changes:

- **crypto**: fix regression on randomFillSync (James M Snell)
  (#35723)
  - This fixes issue #35722.
- **deps**: upgrade npm to 7.0.3 (Ruy Adorno)
  (#35724)
- **doc**: add release key for Danielle Adams (Danielle Adams)
  (#35545)

PR-URL: #35736
BethGriggs pushed a commit that referenced this issue Oct 21, 2020
Notable changes:

- **crypto**: fix regression on randomFillSync (James M Snell)
  (#35723)
  - This fixes issue #35722.
- **deps**: upgrade npm to 7.0.3 (Ruy Adorno)
  (#35724)
- **doc**: add release key for Danielle Adams (Danielle Adams)
  (#35545)

PR-URL: #35736
BethGriggs pushed a commit that referenced this issue Oct 21, 2020
Notable changes:

- **crypto**: fix regression on randomFillSync (James M Snell)
  (#35723)
  - This fixes issue #35722.
- **deps**: upgrade npm to 7.0.3 (Ruy Adorno)
  (#35724)
- **doc**: add release key for Danielle Adams (Danielle Adams)
  (#35545)

PR-URL: #35736
BethGriggs added a commit that referenced this issue Dec 8, 2020
Add Danielle Adams's release key.

PR-URL: #35545
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
BethGriggs added a commit that referenced this issue Dec 10, 2020
Add Danielle Adams's release key.

PR-URL: #35545
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@BethGriggs BethGriggs mentioned this pull request Dec 10, 2020
BethGriggs added a commit that referenced this issue Dec 15, 2020
Notable Changes:

- **deps**:
  - upgrade npm to 6.14.9 (Myles Borins)
    #36450
  - update acorn to v8.0.4 (Michaël Zasso)
    #35791
- **doc**: add release key for Danielle Adams (Danielle Adams)
    #35545
- **http2**: check write not scheduled in scope destructor (David Halls)
    #36241
- **stream**: fix regression on duplex end (Momtchil Momtchev)
    #35941

PR-URL: #36476
BethGriggs added a commit that referenced this issue Dec 15, 2020
Add Danielle Adams's release key.

PR-URL: #35545
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
BethGriggs added a commit that referenced this issue Dec 15, 2020
Notable Changes:

- **deps**:
  - upgrade npm to 6.14.9 (Myles Borins)
    #36450
  - update acorn to v8.0.4 (Michaël Zasso)
    #35791
- **doc**: add release key for Danielle Adams (Danielle Adams)
    #35545
- **http2**: check write not scheduled in scope destructor (David Halls)
    #36241
- **stream**: fix regression on duplex end (Momtchil Momtchev)
    #35941

PR-URL: #36476
BethGriggs added a commit that referenced this issue Dec 15, 2020
Notable Changes:

- **deps**:
  - upgrade npm to 6.14.9 (Myles Borins)
    #36450
  - update acorn to v8.0.4 (Michaël Zasso)
    #35791
- **doc**: add release key for Danielle Adams (Danielle Adams)
    #35545
- **http2**: check write not scheduled in scope destructor (David Halls)
    #36241
- **stream**: fix regression on duplex end (Momtchil Momtchev)
    #35941

PR-URL: #36476
richardlau added a commit that referenced this issue Jan 19, 2021
Add Danielle Adams's release key.

PR-URL: #35545
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@richardlau richardlau mentioned this pull request Jan 22, 2021
@targos targos removed the commit-queue-failed label Sep 5, 2021
@danielleadams danielleadams deleted the add-danielleadams-gpg-key branch Mar 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc notable-change
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

9 participants