Check write not scheduled in scope destructor #33156 #36241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
|
@nodejs/releasers Could/should this be targeted at the v12.x-staging branch rather than master? Or is targeting the master branch the right way to go? |
|
I think we should add the test to master anyway - I'm not sure we should skip the fix. |
|
This needs another review and it can land cc @nodejs/http2 @ronag @jasnell |
Trott
approved these changes
Dec 1, 2020
|
Landed in 83166fb |
4 tasks
4 tasks
Merged
cjihrig
pushed a commit
to cjihrig/node
that referenced
this issue
Dec 8, 2020
Fixes: nodejs#33156 PR-URL: nodejs#36241 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Merged
BethGriggs
added a commit
that referenced
this issue
Dec 15, 2020
Notable Changes:
- **deps**:
- upgrade npm to 6.14.9 (Myles Borins)
#36450
- update acorn to v8.0.4 (Michaël Zasso)
#35791
- **doc**: add release key for Danielle Adams (Danielle Adams)
#35545
- **http2**: check write not scheduled in scope destructor (David Halls)
#36241
- **stream**: fix regression on duplex end (Momtchil Momtchev)
#35941
PR-URL: #36476
BethGriggs
added a commit
that referenced
this issue
Dec 15, 2020
Notable Changes:
- **deps**:
- upgrade npm to 6.14.9 (Myles Borins)
#36450
- update acorn to v8.0.4 (Michaël Zasso)
#35791
- **doc**: add release key for Danielle Adams (Danielle Adams)
#35545
- **http2**: check write not scheduled in scope destructor (David Halls)
#36241
- **stream**: fix regression on duplex end (Momtchil Momtchev)
#35941
PR-URL: #36476
BethGriggs
added a commit
that referenced
this issue
Dec 15, 2020
Notable Changes:
- **deps**:
- upgrade npm to 6.14.9 (Myles Borins)
#36450
- update acorn to v8.0.4 (Michaël Zasso)
#35791
- **doc**: add release key for Danielle Adams (Danielle Adams)
#35545
- **http2**: check write not scheduled in scope destructor (David Halls)
#36241
- **stream**: fix regression on duplex end (Momtchil Momtchev)
#35941
PR-URL: #36476
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
See issue comment
This isn't needed for Node 15 but does fix Node 12. I couldn't see a way to make a PR against Node 12 however. The diff for the Node 12 fix is in the issue comment.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes