Repository navigation
fix: invalidate stale raw spelling on combinator value assignment - #342
Merged
Merged
Conversation
MoOx
added a commit
to theRizwan/postcss-selector-parser
that referenced
this pull request
Nov 8, 2026
* origin/main: fix: preserve selector delimiters after escaped backslashes (postcss#354) fix: keep the processor's entry points usable when destructured feat: support the case-sensitive attribute flag (s) per Selectors Level 4 (postcss#327) fix: escape values assigned to an id through the value setter (postcss#326) fix: escape class values supplied to the constructor (postcss#349) fix: preserve the spaces declared on selector and root containers (postcss#356) fix: forward the default options given to the parser factory (postcss#345) 7.1.8 fix: remove four more quadratic paths from selector parsing chore(deps): bump tinypool and oxfmt (postcss#351) 7.1.7 docs: add CVE-2026-104844 to the 7.1.6 changelog entry fix: keep whitespace around the namespace separator in attribute selectors (postcss#339) fix: invalidate stale raw spelling on combinator value assignment (postcss#342) fix: set parents for all variadic inserted nodes (postcss#343) Consume whitespace after hexadecimal CSS escapes (postcss#340) fix: lossless mode drops whitespace when a selector ends empty (postcss#337) chore(deps-dev): bump source-map-js from 1.2.1 to 1.2.2 (postcss#347) 7.1.6 fix: parse flat selectors in linear time, closing a CPU exhaustion vulnerability # Conflicts: # src/parser.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #196.
After parsing
a\tb, assigningcombinator.value = ">"still serializes the old tab becauseraws.valuewins over the new value. Clear that stale raw spelling on explicit assignment, while preserving constructor-provided raw text, unchanged clones, and the existing raw-property helpers. Assigning the same semantic space also normalizes a tab or newline as requested in the issue.Document that replacing the value replaces comments embedded in
raws.value; comments stored separately in raw spacing remain intact. Add regression tests for whitespace, named combinators, constructor option order, clone isolation, and raw helper behavior.Validation on Node 26.3.0: seven regression assertions fail before the fix; all 75 focused tests and all 813 full-suite tests pass afterward. Coverage gates pass (94.96% lines, 95.50% branches, 97.72% functions). Build, lint, changed-source formatting, and strict declaration tests with project-local type roots pass.
The default typecheck picks up unrelated ancestor
@types/nodedeclarations and reports three errors there; the strict check with--typeRoots ./node_modules/@typespasses without skipping library checks. Full formatting reports only the unchangedsrc/__tests__/exceptions.mjs; lint has two existing warnings in that file.OpenAI Codex assisted with the code, tests, and description. The final patch received an independent AI review.