Repository navigation
fix: escape class values supplied to the constructor - #349
Merged
Merged
Conversation
MoOx
added a commit
to wozhenbang2004/postcss-selector-parser
that referenced
this pull request
Nov 8, 2026
* origin/main: feat: support the case-sensitive attribute flag (s) per Selectors Level 4 (postcss#327) fix: escape values assigned to an id through the value setter (postcss#326) fix: escape class values supplied to the constructor (postcss#349) fix: preserve the spaces declared on selector and root containers (postcss#356) fix: forward the default options given to the parser factory (postcss#345) 7.1.8 fix: remove four more quadratic paths from selector parsing # Conflicts: # src/parser.js
MoOx
added a commit
to theRizwan/postcss-selector-parser
that referenced
this pull request
Nov 8, 2026
* origin/main: fix: preserve selector delimiters after escaped backslashes (postcss#354) fix: keep the processor's entry points usable when destructured feat: support the case-sensitive attribute flag (s) per Selectors Level 4 (postcss#327) fix: escape values assigned to an id through the value setter (postcss#326) fix: escape class values supplied to the constructor (postcss#349) fix: preserve the spaces declared on selector and root containers (postcss#356) fix: forward the default options given to the parser factory (postcss#345) 7.1.8 fix: remove four more quadratic paths from selector parsing chore(deps): bump tinypool and oxfmt (postcss#351) 7.1.7 docs: add CVE-2026-104844 to the 7.1.6 changelog entry fix: keep whitespace around the namespace separator in attribute selectors (postcss#339) fix: invalidate stale raw spelling on combinator value assignment (postcss#342) fix: set parents for all variadic inserted nodes (postcss#343) Consume whitespace after hexadecimal CSS escapes (postcss#340) fix: lossless mode drops whitespace when a selector ends empty (postcss#337) chore(deps-dev): bump source-map-js from 1.2.1 to 1.2.2 (postcss#347) 7.1.6 fix: parse flat selectors in linear time, closing a CPU exhaustion vulnerability # Conflicts: # src/parser.js
MoOx
added a commit
that referenced
this pull request
Nov 12, 2026
This reverts commit b74fdd4. The constructor had written `value` verbatim since 2018, and callers rely on it: postcss-modules-scope passes the name css-loader has already escaped, which 7.2.0 escaped a second time, so CSS Modules selectors stopped matching (#362). The change moves to the next major (#357).
This was referenced Nov 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #182.
parser.className({ value: "hover:bg-blue" })currently serializes as.hover:bg-blue, while assigning the same value after construction correctly escapes the colon. Initialize constructor values through the existing escaping setter unless an explicitraws.valuewas supplied.Keep parsed selectors lossless by retaining their original spelling and raw AST shape. Regression coverage includes identifier punctuation, leading digits, backslashes, Unicode, explicit raw spelling in either option order, cloning, and Less interpolation.
Validation on Node 26.7.0: six regression assertions fail before the fix; all 109 focused tests and all 806 full-suite tests pass afterward. Coverage gates pass (95.02% lines, 95.50% branches, 97.70% functions). Build, lint, changed-file formatting, and strict declaration checks using project-local type roots pass.
The default declaration check picks up unrelated ancestor
@types/nodedeclarations and reports three unchanged errors; the strict check with--typeRoots ./node_modules/@typespasses without skipping library checks. Full formatting reports only the unchangedsrc/__tests__/exceptions.mjs; lint reports two existing warnings there.OpenAI Codex assisted with the code, tests, and description. The final patch received an independent AI review.