Sitelet https://github.com/postcss/postcss-selector-parser/pull/340
Skip to content

fix: consume whitespace after hexadecimal escapes - #340

Merged
MoOx merged 1 commit into
postcss:mainfrom
jakezwang:fix-hex-escape-whitespace
Oct 19, 2026
Merged

MoOx merged 1 commit into
postcss:mainfrom
jakezwang:fix-hex-escape-whitespace

Conversation

@jakezwang

Copy link
Copy Markdown

Parsing [x="\000061 b"] currently produces the attribute value a b instead of ab. Changing the node's quote mark then serializes a selector matching a different value.

Consume the optional CSS whitespace after the hexadecimal digits, including after a six-digit escape. Handle CRLF as one newline and preserve the original raw selector. Add public parser regressions for each whitespace form, replacement characters, and boundaries that must stay in the value.

Validation: 15 regression cases fail before the fix. npm test passes lint, types, coverage thresholds, and all 834 tests on Node 24 and 26. The existing 30 unescape tests also pass; 48 original/reserialized selector pairs match the expected attribute in Chrome. Changed-file formatting passes; the full formatting check flags only unchanged src/__tests__/exceptions.mjs.

@MoOx
MoOx merged commit 8b2d16d into postcss:main Oct 19, 2026
MoOx added a commit to theRizwan/postcss-selector-parser that referenced this pull request Nov 8, 2026
* origin/main:
  fix: preserve selector delimiters after escaped backslashes (postcss#354)
  fix: keep the processor's entry points usable when destructured
  feat: support the case-sensitive attribute flag (s) per Selectors Level 4 (postcss#327)
  fix: escape values assigned to an id through the value setter (postcss#326)
  fix: escape class values supplied to the constructor (postcss#349)
  fix: preserve the spaces declared on selector and root containers (postcss#356)
  fix: forward the default options given to the parser factory (postcss#345)
  7.1.8
  fix: remove four more quadratic paths from selector parsing
  chore(deps): bump tinypool and oxfmt (postcss#351)
  7.1.7
  docs: add CVE-2026-104844 to the 7.1.6 changelog entry
  fix: keep whitespace around the namespace separator in attribute selectors (postcss#339)
  fix: invalidate stale raw spelling on combinator value assignment (postcss#342)
  fix: set parents for all variadic inserted nodes (postcss#343)
  Consume whitespace after hexadecimal CSS escapes (postcss#340)
  fix: lossless mode drops whitespace when a selector ends empty (postcss#337)
  chore(deps-dev): bump source-map-js from 1.2.1 to 1.2.2 (postcss#347)
  7.1.6
  fix: parse flat selectors in linear time, closing a CPU exhaustion vulnerability

# Conflicts:
#	src/parser.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants