fix: replace dead ci-keys.zkmopro.org links by moven0831 · Pull Request #725 · zkmopro/mopro

moven0831 · 2026-07-29T14:47:31Z

Fix dead `ci-keys.zkmopro.org` links

Follow-up to and close [BUG] rapidsnark.zkmopro.org no longer resolves #724, alongside fix: fetch rapidsnark prebuilts from the upstream GitHub release rust-rapidsnark#12.

Problem

ci-keys.zkmopro.org no longer resolves (same lapsed zone as rapidsnark.zkmopro.org), so the Rust setup guide, React Native SDK page, and EthTaipei workshop all fail with curl: (6) Could not resolve host.

Changes

Every link now points at a fixture already committed in the org, pinned to a tag or commit so it can't drift:

File	New source
`multiplier2.wasm`, `multiplier2_final.zkey`	this repo @ `mopro-cli-v0.3.7`
keccak256 wasm + zkey	rust-rapidsnark @ `v0.1.4` (only committed copies)
`keccak256.json`	circuit-registry `keccak256/input.json` — verified identical to the 256 values the workshop pastes inline

The 0.1 and 0.2 docs carried the same dead host and are updated too.

Also:

Circom adapter page now notes that rust-rapidsnark 0.1.4 dropped x86_64-apple-ios (upstream builds libfr.a/libfq.a arm64-only for the simulator). mopro still offers that arch, so an Intel Mac would otherwise fail with no explanation.
cli_template_tests now builds a scaffolded circom project with the rapidsnark feature enabled. Nothing in CI compiled rust-rapidsnark before — scaffolded projects leave the feature off — which is how a download endpoint could break for users while CI stayed green. Runs on both runners; the Ubuntu leg would have caught the Linux link failure in rust-rapidsnark#12.

Summary by CodeRabbit

New Features
- Enhanced the scaffold validation to build Circom projects with the Rapidsnark feature enabled.
Tests
- Added an explicit verification that the required feature is present before building, and improved the related failure message.
Documentation
- Updated Circom, Rust, React Native, and workshop guides to use newer raw GitHub download links for circuit artifacts and test vectors.
- Added clarification about missing prebuilt iOS covers and how to build the Intel Mac simulator using a local library path.

coderabbitai · 2026-07-29T14:48:03Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: a1325f44-aa30-4353-a3ba-5caefb346eb4

📥 Commits

Reviewing files that changed from the base of the PR and between f9e957d and efda7e5.

📒 Files selected for processing (1)

.github/workflows/build-and-test.yml

🚧 Files skipped from review as they are similar to previous changes (1)

.github/workflows/build-and-test.yml

📝 Walkthrough

Walkthrough

The Circom template CI workflow now builds with rapidsnark enabled. Documentation replaces circuit asset URLs with GitHub raw links and documents Intel Mac simulator library requirements.

Changes

Rapidsnark validation and documentation

Layer / File(s)	Summary
Rapidsnark feature build validation `.github/workflows/build-and-test.yml`	The Circom CI job enables, verifies, and builds the `rapidsnark` feature.
Documentation links and platform guidance `docs/blog/...`, `docs/docs/...`, `docs/versioned_docs/...`	Circuit WASM, zkey, and input URLs now use GitHub-hosted assets, and Circom documentation describes local libraries required for Intel Mac simulator builds.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related issues

[[BUG] rapidsnark.zkmopro.org no longer resolves #724] The changes add rapidsnark CI coverage, document the Intel Mac simulator limitation, and replace deprecated circuit asset URLs.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title matches the main link-replacement theme, though it omits the CI and rapidsnark updates.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch fix/dead-ci-keys-urls

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

cloudflare-workers-and-pages · 2026-07-29T14:49:48Z

Deploying mopro with Cloudflare Pages

Latest commit:	`efda7e5`
Status:	✅ Deploy successful!
Preview URL:	https://246ba58b.mopro.pages.dev
Branch Preview URL:	https://fix-dead-ci-keys-urls.mopro.pages.dev

View logs

coderabbitai

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@docs/docs/adapters/circom.md`:
- Line 305: Update the Intel Mac simulator note in the circom adapter
documentation to state explicitly that rust-rapidsnark 0.1.4 provides no
prebuilt libraries for x86_64-apple-ios. Replace the ambiguous “covers” wording
while preserving the instruction to set RAPIDSNARK_LIB_DIR to a custom build.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

Push a commit to this branch (recommended)
Create a new PR with the fixes

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 731a363c-c458-4c49-9b78-333d99165a06

📥 Commits

Reviewing files that changed from the base of the PR and between 10871f0 and 260c7df.

📒 Files selected for processing (7)

.github/workflows/build-and-test.yml
docs/blog/2025-03-27-ethtaipei-workshop.md
docs/docs/adapters/circom.md
docs/docs/sdk/react-native.md
docs/docs/setup/rust-setup.md
docs/versioned_docs/version-0.1/setup/react-native-setup.md
docs/versioned_docs/version-0.2/setup/rust-setup.md

coderabbitai · 2026-07-29T14:51:18Z


 -   `rust-rapidsnark` is based on the original C++ implementation of [rapidsnark](https://github.com/iden3/rapidsnark), with the binary wrapped and integrated in Rust.
 -   Activate `rapidsnark` Feature for both `[dependencies]` and `[build-dependencies]`
+-   No prebuilt covers `x86_64-apple-ios`. To build for the Intel Mac simulator, point `RAPIDSNARK_LIB_DIR` at your own build of those libraries.


📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win

Scope and clarify the Intel simulator limitation.

The PR targets rust-rapidsnark 0.1.4, but this sentence reads as an unversioned permanent limitation and “covers” is unclear. Specify that no prebuilt libraries are available for this target in 0.1.4.

Proposed wording

-- No prebuilt covers `x86_64-apple-ios`. To build for the Intel Mac simulator, point `RAPIDSNARK_LIB_DIR` at your own build of those libraries. +- For `rust-rapidsnark` 0.1.4, no prebuilt libraries are available for `x86_64-apple-ios`. To build for the Intel Mac simulator, point `RAPIDSNARK_LIB_DIR` at your own build of those libraries.

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change

- No prebuilt covers `x86_64-apple-ios`. To build for the Intel Mac simulator, point `RAPIDSNARK_LIB_DIR` at your own build of those libraries.

- For `rust-rapidsnark` 0.1.4, no prebuilt libraries are available for `x86_64-apple-ios`. To build for the Intel Mac simulator, point `RAPIDSNARK_LIB_DIR` at your own build of those libraries.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@docs/docs/adapters/circom.md` at line 305, Update the Intel Mac simulator note in the circom adapter documentation to state explicitly that rust-rapidsnark 0.1.4 provides no prebuilt libraries for x86_64-apple-ios. Replace the ambiguous “covers” wording while preserving the instruction to set RAPIDSNARK_LIB_DIR to a custom build.

ci-keys.zkmopro.org stopped resolving, so following the setup guide or the EthTaipei workshop hit "curl: (6) Could not resolve host". Point at the fixtures committed in this repo and in rust-rapidsnark instead, pinned to a tag or commit so they cannot drift. The versioned 0.1 and 0.2 copies carried the same dead host, so they are updated too. keccak256.json becomes circuit-registry's keccak256/input.json, which is byte-identical to the input the workshop already pastes inline. Also note that rapidsnark has no x86_64-apple-ios prebuilt, since rust-rapidsnark 0.1.4 dropped that target, and building it now needs RAPIDSNARK_LIB_DIR. Finally, cover the rapidsnark feature in cli_template_tests. Scaffolded projects leave it off, so nothing in CI compiled rust-rapidsnark or fetched its prebuilt libraries, which is why a download endpoint could break for users without CI noticing. Runs on both macos-latest and ubuntu-latest. Refs #724 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

moven0831 · 2026-07-30T07:29:48Z

rapid-snark feature check on CI has been added. Logs as below:

https://github.com/zkmopro/mopro/actions/runs/30463110309/job/90618885679#logs

The grep guard's error message named write_toml.rs, which only emits the # CIRCOM_DEPENDENCIES marker. The circom-prover line the sed pattern matches comes from the DEPENDENCIES const in cli/src/init/circom.rs. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

moven0831 changed the title ~~fix(docs): replace dead ci-keys.zkmopro.org download links~~ fix: replace dead ci-keys.zkmopro.org links Jul 29, 2026

coderabbitai Bot reviewed Jul 29, 2026

View reviewed changes

moven0831 force-pushed the fix/dead-ci-keys-urls branch from 260c7df to f9e957d Compare July 29, 2026 14:53

moven0831 merged commit a2ccb0c into main Jul 30, 2026
55 checks passed

coderabbitai Bot mentioned this pull request Aug 15, 2026

feat(circom): add optional Garaga Starknet calldata helper #723

Open

Navigation Menu

fix: replace dead ci-keys.zkmopro.org links - #725

fix: replace dead ci-keys.zkmopro.org links#725
moven0831 merged 2 commits into
mainfrom
fix/dead-ci-keys-urls

moven0831 commented Jul 29, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

coderabbitai Bot commented Jul 29, 2026 •

edited

Loading

Walkthrough

Changes

Uh oh!

cloudflare-workers-and-pages Bot commented Jul 29, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot left a comment

Uh oh!

coderabbitai Bot Jul 29, 2026

Uh oh!

moven0831 commented Jul 30, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

	- No prebuilt covers `x86_64-apple-ios`. To build for the Intel Mac simulator, point `RAPIDSNARK_LIB_DIR` at your own build of those libraries.
	- For `rust-rapidsnark` 0.1.4, no prebuilt libraries are available for `x86_64-apple-ios`. To build for the Intel Mac simulator, point `RAPIDSNARK_LIB_DIR` at your own build of those libraries.

Conversation

moven0831 commented Jul 29, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Fix dead ci-keys.zkmopro.org links

Problem

Changes

Summary by CodeRabbit

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Jul 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Uh oh!

cloudflare-workers-and-pages Bot commented Jul 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Deploying mopro with Cloudflare Pages

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

coderabbitai Bot Jul 29, 2026

Choose a reason for hiding this comment

Uh oh!

moven0831 commented Jul 30, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

moven0831 commented Jul 29, 2026 •

edited by coderabbitai Bot

Loading

Fix dead `ci-keys.zkmopro.org` links

coderabbitai Bot commented Jul 29, 2026 •

edited

Loading

cloudflare-workers-and-pages Bot commented Jul 29, 2026 •

edited

Loading