Sitelet https://github.com/yuandrew/cli/pull/1
Skip to content

Create new "string-enum[]" type - #1

Draft
yuandrew wants to merge 15 commits into
command-yaml-generationfrom
string-enum-array
Draft

yuandrew wants to merge 15 commits into
command-yaml-generationfrom
string-enum-array

Conversation

@yuandrew

Copy link
Copy Markdown
Owner

TODO: add a test?

yuandrew and others added 15 commits September 18, 2024 14:42
## What was changed
Moved from Markdown to YAML for CLI command generation.

This switch also fixes a bug where option set aliases weren't being
persisted to commands that use them (i.e.
`NewTemporalScheduleCreateCommand`)

## Why?
More standardized format, easier to parse and add to

## Checklist
<!--- add/delete as needed --->

1. Closes temporalio#620 

2. How was this tested:
<!--- Please describe how you tested your changes/how we can test them
-->
Passes all CI tests

3. Any docs updates needed?
<!--- update README if applicable
      or point out where to update docs.temporal.io -->
<!--- Note to EXTERNAL Contributors -->
<!-- Thanks for opening a PR! 
If it is a significant code change, please **make sure there is an open
issue** for this.
We work best with you when we have accepted the idea first before you
code. -->

<!--- For ALL Contributors 👇 -->

## What was changed
<!-- Describe what has changed in this PR -->

Added support for passing --rps flag to batch operations.
Co-authored-by: David Reiss <dnr@dnr.im>
yuandrew pushed a commit that referenced this pull request Jul 13, 2026
## Related issues

Related to #[1104](temporalio#1104)

## What changed?

<!-- Describe what this PR does at a high level. -->
This adds a command-line option that configures the embedded UI server
to disable the news feed feature.

## Checklist

<!-- Your PR should satisfy all these requirements. However, feel free
to remove items that don't apply to the PR. Consider giving this
checklist to an AI agent before opening your PR. -->

## Manual tests

<!-- Edit the code samples below to provide setup and happy-path and
error-path testing instructions. -->

**Setup #1 (default case)**
```
temporal server start-dev
```

**Happy path #1 (default case)**
Open the Web UI and observe that the news fetch feature is enabled, as
it is by default. This is visible by way of a megaphone icon in the top
navigation.



**Setup two (feature disabled)**
```
temporal server start-dev --ui-disable-news-fetch
```

**Happy path two (feature disabled)**
Open the Web UI and observe that the news fetch feature is disabled,
since the environment variable is set to disable it, as described in the
documentation. This is evident by the megaphone icon being omitted from
the top navigation and the Web UI not making a request for the feed.

---------

Co-authored-by: alex.stanfield <13949480+chaptersix@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants