fix(E2BIG): Ignore potentially large vscode keys - #7419

@BYK I submitted the simple version. Wasn't sure where a warning should really go -- directly here: https://github.com/eamodio/yarn/blob/dfe97900ca5f425d8cf303477b66073f4f6cb812/src/util/execute-lifecycle-script.js#L104?

I think this version is fine since you did not add dropping random stuff based on their sizes. I'll leave the final say to @arcanis.

Btw. I think you need to update some tests or add new ones :)

Updated with lint fixes -- oops 😄

@arcanis @BYK Does this looks good? Or do I need to make any other changes?

@eamodio as mentioned before, there should be some updated tests for this change. I'm also waiting for @arcanis to sign off. Guessing he's busy nowadays so will ping him directly.

Sounds all good to me! ☺️ Can you update the changelog?

@BYK OK, I figured the existing test was enough, since it enumerates all the keys in that list. What else should I test?

@arcanis Will do.

@BYK OK, I figured the existing test was enough, since it enumerates all the keys in that list. What else should I test?

Hahaha sorry, my bad. I forgot my own refactor making this test future-proof :)

Hooray! Thank you!

@BYK @arcanis any idea of an ETA on the next release of yarn that would include this fix?

@eamodio not sure about the next release but if you need it, you can use the nightly builds safely as a release is just a tagged version of those (and some packaging magic).