Sitelet https://github.com/yarnpkg/yarn/pull/6926
Skip to content

fix(run): Preserve none zero exit code - #6926

Merged
arcanis merged 12 commits into
yarnpkg:masterfrom
zhigang1992:preserveExitCode
Mar 14, 2019
Merged

fix(run): Preserve none zero exit code#6926
arcanis merged 12 commits into
yarnpkg:masterfrom
zhigang1992:preserveExitCode

Conversation

@zhigang1992

@zhigang1992 zhigang1992 commented Jan 15, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor

resolve #6925

Summary

index.js

const process = require('process');
process.exit(78)

npm start will yield 78, but yarn start will yield 1.

screen shot 2019-01-15 at 8 44 31 pm

  • Fix yarn node index.js
  • Fix yarn start

Test plan

  • Having unit test covering the exit code

zhigang1992
zhigang1992 commented Jan 15, 2019
View reviewed changes
Comment thread src/cli/index.js
@zhigang1992 zhigang1992 changed the title WIP: Preserve none zero exit code Preserve none zero exit code Jan 15, 2019
zhigang1992
zhigang1992 commented Jan 15, 2019
View reviewed changes
Comment thread src/cli/index.js Outdated
@zhigang1992 zhigang1992 changed the title Preserve none zero exit code fix(run): Preserve none zero exit code Jan 15, 2019
@zhigang1992 zhigang1992 mentioned this pull request Jan 16, 2019
Closed
arcanis
arcanis requested changes Jan 23, 2019
View reviewed changes
Comment thread src/cli/index.js Outdated
Comment thread src/util/execute-lifecycle-script.js Outdated
@zhigang1992

zhigang1992 commented Feb 8, 2019

Copy link
Copy Markdown
Contributor Author

@arcanis please take another look.

@arcanis
arcanis merged commit bb69888 into yarnpkg:master Mar 14, 2019
@buildsize

buildsize Bot commented Mar 14, 2019 •
edited
Loading

Copy link
Copy Markdown
File name Previous Size New Size Change
yarn-[version].noarch.rpm 1.11 MB 1.11 MB -1.89 KB (0%)
yarn-[version].js 4.47 MB 4.47 MB -3.37 KB (0%)
yarn-legacy-[version].js 4.67 MB 4.66 MB -3.99 KB (0%)
yarn-v[version].tar.gz 1.12 MB 1.12 MB -20 bytes (0%)
yarn_[version]all.deb 816.45 KB 815.75 KB -718 bytes (0%)

@zhigang1992
zhigang1992 deleted the preserveExitCode branch March 14, 2019 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@arcanis arcanis arcanis requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Preserve none zero exit code

2 participants

@zhigang1992 @arcanis