Sitelet https://github.com/yarnpkg/yarn/pull/6467
Skip to content

Disable semantic commit prefixes for Renovate - #6467

Merged
arcanis merged 1 commit into
yarnpkg:masterfrom
rarkins:patch-1
Oct 2, 2018
Merged

arcanis merged 1 commit into
yarnpkg:masterfrom
rarkins:patch-1

Conversation

@rarkins

@rarkins rarkins commented Oct 2, 2018

Copy link
Copy Markdown
Contributor

Summary

As suggested by @edmorley here: #6463 (comment)

This will prevent Renovate from autodetecting semantic commits have been added to master and switching them on automatically, and instead just keep them permanently off.

Test plan

No tests required or changelog update as this is bot config internal to this repo only.

As suggested by @edmorley here: #6463 (comment)

This will prevent Renovate from autodetecting semantic commits have been added to master and switching them on automatically, and instead just keep them permanently off.

@edmorley edmorley left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me!

For the reviewers, some more context:

By default if the semantic commits mode isn't set explicitly, Renovate uses auto-detection which looks at the style used in the most recent 10 commits:
https://github.com/renovatebot/renovate/blob/bf3f0862407c304c5ddde59fd0c20607c7e5f0ee/lib/workers/repository/init/semantic.js#L13-L18

However the commits in the Yarn repository inconsistently use semantic commits style, meaning that Renovate's "auto" mode flip-flops back and forth between semantic commits style being enabled and not. This results in inconsistent Renovate PR titles and commit messages, which aside from being suboptimal aesthetically, confuses Renovate's "an existing PR was already closed without being merged, don't open another" feature - and is why a number of duplicate PRs were opened up today.

Links to docs:
https://renovatebot.com/docs/configuration-options/#semanticcommits
https://renovatebot.com/docs/presets-default/#semanticcommitsdisabled

@edmorley

edmorley commented Oct 2, 2018

Copy link
Copy Markdown
Contributor

The CI failures appear on master too, and are from #6454.

@arcanis

arcanis commented Oct 2, 2018

Copy link
Copy Markdown
Member

Thanks! 😃

@arcanis
arcanis merged commit dfe046c into yarnpkg:master Oct 2, 2018
@rarkins
rarkins deleted the patch-1 branch October 2, 2018 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants