Sitelet https://github.com/yarnpkg/yarn/pull/5145/files
Skip to content

feat(cli): improve error message when file resolver can't find file (#5134) #5145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
arcanis merged 3 commits into from
Jan 15, 2018
Merged

feat(cli): improve error message when file resolver can't find file (#5134) #5145

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b13e090
feat(cli): improve error message when file resolver can't find file (…
iansu Jan 2, 2018
2e9ab96
Update en.js
arcanis Jan 15, 2018
f7ccba6
Update en.js
arcanis Jan 15, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/reporters/lang/en.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ const messages = {
invalidVersion: 'Invalid version supplied.',
requiredVersionInRange: 'Required version in range.',
packageNotFoundRegistry: "Couldn't find package $0 on the $1 registry.",
doesntExist: "$0 doesn't exist.",
doesntExist: "Package $1 refers to a non-existing file '$0'.",
missingRequiredPackageKey: `Package $0 doesn't have a $1.`,
invalidAccess: 'Invalid argument for access, expected public or restricted.',
invalidCommand: 'Invalid subcommand. Try $0',
Expand Down
2 changes: 1 addition & 1 deletion src/resolvers/exotics/file-resolver.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ export default class FileResolver extends ExoticResolver {
return manifest;
}
if (!await fs.exists(loc)) {
throw new MessageError(this.reporter.lang('doesntExist', loc));
throw new MessageError(this.reporter.lang('doesntExist', loc, this.pattern.split('@')[0]));
}

const manifest: Manifest = await (async () => {
Expand Down