Sitelet https://github.com/webpack-contrib/bundle-loader/pull/70
Skip to content
This repository was archived by the owner on Jun 25, 2020. It is now read-only.

fix(index): add rootContext (this.rootContext) - #70

Merged
michael-ciniawsky merged 1 commit into
webpack-contrib:masterfrom
statianzo:webpack-4
Feb 5, 2018
Merged

michael-ciniawsky merged 1 commit into
webpack-contrib:masterfrom
statianzo:webpack-4

Conversation

@statianzo

Copy link
Copy Markdown
Contributor

Webpack 4 removed this.options from loaders. The replacement for
this.options.context is this.rootContext.

this.options and this.rootContext
webpack 3 already deprecated this.options in the loader context. webpack 4 removes it now.

A lot of people are missing the this.options.context value now. It has been added as this.rootContext.

https://medium.com/webpack/webpack-4-migration-guide-for-plugins-loaders-20a79b927202

Fixes #69

Webpack 4 removed `this.options` from loaders. The replacement for
`this.options.context` is `this.rootContext`.
@jsf-clabot

jsf-clabot commented Jan 30, 2018 •

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@alexander-akait alexander-akait left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for PR

@alexander-akait alexander-akait added this to the v0.5.6 milestone Jan 31, 2018
@michael-ciniawsky michael-ciniawsky changed the title webpack 4: use loaderContext.rootContext fix(index): add rootContext (this.rootContext) Feb 5, 2018

@michael-ciniawsky michael-ciniawsky left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@michael-ciniawsky

Copy link
Copy Markdown
Member

Released in v0.5.6 🎉 Thx

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants