Repository navigation
Conversation
✅ Deploy Preview for w3c-string-search ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
aphillips
reviewed
Sep 27, 2026
aphillips
left a comment
Contributor
There was a problem hiding this comment.
Great addition. Thanks.
Comment on lines
+151
to
+152
| <section id="non-body-text"> | ||
| <h3>Annotations and non-body text</h3> |
Contributor
There was a problem hiding this comment.
Looking at the preview, I think we should consider the structure of section 2 more carefully. My first reaction was that this subsection belongs down near word boundaries (at the end of the section), but my second reaction was that the subsection about problems matching text maybe should be pulled out into a new section 3. This isn't something you should do in this PR--I'll file an issue for it. But mentioning here.
aphillips
reviewed
Sep 28, 2026
aphillips
left a comment
Contributor
There was a problem hiding this comment.
We're working in parallel, so submitting comment.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #22.