Repository navigation
Fix AppBundle namespace issue - #34
Merged
Merged
Conversation
Contributor
Author
|
I am observing that are a little issues with CompilerPass also. I will try to investigate later. I think that we will need create another PR because it isn't related with that. |
Contributor
Author
|
Ok my last message is related with old configuration, but nothing to worry. This PR will fix the namespace issues. Thank you |
Brunty
approved these changes
Dec 5, 2017
Contributor
|
@leightonthomas can you double check this? |
leightonthomas
approved these changes
Dec 5, 2017
Contributor
Author
|
Hello, Could be merged and tagged? Thank you ;) |
Contributor
|
@terox done, thanks! (apologies for the delay) :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello again,
Seems that 2.1 tag is broken. There are some issue with namespaces.
This are not detected by tests because they are not tested.
This will fix it.
Thank you