Repository navigation
Uuid generator - #30
Conversation
|
Hi Terox, thanks for the contribution, I'm a concerned that the StringGeneratorBundle could become a tangle of dependencies if they're all under the https://getcomposer.org/doc/04-schema.md#suggest Then the package can use a UUID generator if that package has been installed, but it will not be installed by default. I appreciate that this is already an issue with the I'll put it to the team however. |
|
Hi! I understand perfectly what are you saying. I will review it in a few days and I will move the dependencie as a composer suggest. I will add also a checking to check if the library is present or not to thrown an exception (good? :) ). I don't understand the last line (may be my english is not enough good):
I will commit changes as soon as possible :) Thank you |
|
Thanks Terox, that sounds perfect 👍 , we do appreciate your contribution and understanding. Look forward to seeing the commit. The second point was to say that although we already require the |
|
Hi again, First of all sorry the delay. The last months were crazy. I have moved the ramsey/uuid library as a suggested package and updated the README with some information about this generator. Please check if all is fine or need a little more work or refactor. I am listening the suggestions. Note: I think that we should install the suggested package (ramsey/uuid) to pass the tests? Thank you so much |
|
@terox thanks for the work on this, greatly appreciated! I'll get it looked at :) |
Brunty
left a comment
There was a problem hiding this comment.
Approving this, just added a few comments for me to do when it's in master.
| $this->shouldHaveType('Vivait\StringGeneratorBundle\Generator\UuidGenerator'); | ||
| } | ||
|
|
||
| function let() |
| ### `UuidStringGenerator` | ||
| ***For use this generator you should require the package ```ramsey/uuid``` in your application.*** | ||
|
|
||
| For generate a UUID v4 (or v1): |
There was a problem hiding this comment.
Change to: "For generating a UUID"
| /** | ||
| * Constructor. | ||
| */ | ||
| public function __construct() |
|
👍 nice work, @terox! |
|
Thank you ;) I will wait the tag to use in our production projects :) |
Hello every body,
I added an UUID generator as a new generator.
Tests could be better, but I am not a PHPSpec expert.
I hope that it helps