Repository navigation
Fix: services.yml is not compatible with Symfony 3.0 - #27
Merged
Merged
Conversation
This PR fixes the fact that the YAML syntax is not strict and does not anymore pass the Symfony 3.0 Yaml parser or newer PHPUnit Yaml parser.
LewisW
added a commit
that referenced
this pull request
Jan 26, 2016
Fix: services.yml is not compatible with Symfony 3.0
Member
|
Thanks for contributing! |
Contributor
Author
|
You're welcome. It would be good if you can create a release for that. |
Member
|
Sure, does this mean that the string generator bundle now works with Symfony 3.0? |
Contributor
Author
|
I haven't tested that yet. At least it works with latest PHPUnit that uses the same Yaml parser as Symfony 3.0. I haven't tested with Symfony 3.0 directly, yet. |
Member
|
Ah I see. Tagged as 1.2.3. |
Contributor
Author
|
👍🏼 Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the fact that the YAML syntax is not strict and does not anymore pass the Symfony 3.0 Yaml parser or newer PHPUnit Yaml parser.