Sitelet https://github.com/validatorjs/validator.js/pull/1896
Skip to content

Phone number for Lesotho(266) - #1896

Merged
profnandaa merged 13 commits into
validatorjs:masterfrom
DevilsAutumn:master
Apr 22, 2022
Merged

profnandaa merged 13 commits into
validatorjs:masterfrom
DevilsAutumn:master

Conversation

@DevilsAutumn

@DevilsAutumn DevilsAutumn commented Jan 19, 2022 •

Copy link
Copy Markdown
Contributor

Added validation for Lesotho on isMobilePhone.
referred issue : #1761
@tux-tn @ezkemboi

Checklist

  • PR contains only changes related; no stray files, etc.
  • README updated (where applicable)
  • Tests written (where applicable)

@codecov

codecov Bot commented Jan 19, 2022

Copy link
Copy Markdown

Codecov Report

Merging #1896 (934fce0) into master (f055c11) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #1896   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          102       102           
  Lines         2072      2072           
  Branches       472       472           
=========================================
  Hits          2072      2072           
Impacted Files Coverage Δ
src/lib/isMobilePhone.js 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f055c11...934fce0. Read the comment docs.

@rubiin rubiin left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@profnandaa profnandaa left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your contribution!

@profnandaa
profnandaa merged commit 495a175 into validatorjs:master Apr 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants