Sitelet https://github.com/unoplatform/uno/pull/7007
Skip to content

feat: WinUI InfoBadge - #7007

Merged
mergify[bot] merged 2 commits into
unoplatform:masterfrom
DZetko:dev/dazi/infobadge
Sep 13, 2021
Merged

mergify[bot] merged 2 commits into
unoplatform:masterfrom
DZetko:dev/dazi/infobadge

Conversation

@DZetko

@DZetko DZetko commented Sep 9, 2021 •

Copy link
Copy Markdown
Contributor

GitHub Issue (If applicable): #6952

PR Type

What kind of change does this PR introduce?

  • Feature

What is the current behavior?

InfoBadge doesn't work.

What is the new behavior?

InfoBadge works.

PR Checklist

Please check if your PR fulfills the following requirements:

@DZetko
DZetko requested a review from a team September 9, 2021 15:09
@gitpod-io

gitpod-io Bot commented Sep 9, 2021

Copy link
Copy Markdown

@DZetko
DZetko force-pushed the dev/dazi/infobadge branch 4 times, most recently from cbe3c7f to 8f2dacf Compare September 9, 2021 15:14
@DZetko
DZetko force-pushed the dev/dazi/infobadge branch from 8f2dacf to 7a3c754 Compare September 9, 2021 15:16
Comment thread src/Uno.UI/Microsoft/UI/Xaml/Controls/InfoBadge/InfoBadgeTemplateSettings.cs Outdated
Comment thread src/Uno.UI/Microsoft/UI/Xaml/Controls/InfoBadge/InfoBadge.cs
@jeromelaban

Copy link
Copy Markdown
Member

Nice! Were there tests for this control ?

@MartinZikmund

Copy link
Copy Markdown
Member

@jeromelaban There are tests, but I would still merge the control for 3.10, as it will be a nice addition to changelog :-) .

@jeromelaban jeromelaban mentioned this pull request Sep 13, 2021
1 of 2 tasks
@MartinZikmund MartinZikmund added the ready-to-merge Automatically merge the PR once all '.mergify.yml' policies are met label Sep 13, 2021
@mergify
mergify Bot merged commit 839d5ce into unoplatform:master Sep 13, 2021
@MartinZikmund
MartinZikmund deleted the dev/dazi/infobadge branch September 13, 2021 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge Automatically merge the PR once all '.mergify.yml' policies are met

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants