Repository navigation
fix: [MacOS] Fix event handler not invoked in the sample app - #3142
Merged
Merged
Conversation
|
|
Contributor
|
The build 14864 found UI Test snapshots differences.
|
Contributor
|
The build 14864 found UI Test snapshots differences.
|
jeromelaban
approved these changes
May 11, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GitHub Issue: Fixes #3118
Bugfix
Make sure that test runner can be started
What is the current behavior?
The
UserControlare not inserted in the visual tree, so they can be garbage collected, so event handler defined in the code behind are no longer invoked.What is the new behavior?
'UserControl` are now inserted in the visual tree.
PR Checklist
Docs have been added/updated which fit documentation template (for bug fixes / features)Unit Tests and/or UI Tests for the changes have been added (for bug fixes / features) (if applicable)Screenshots Compare Test Runresults.