Conversation
Avoid allocating _inheritedForwardedProperties and _propertyChangedTokens dictionaries during DependencyObject construction until first write. This saves ~176 B per instance and avoids eager allocation for objects that never receive forwarded properties or property changed callbacks. Fixes unoplatform#24752
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoid allocating _inheritedForwardedProperties and _propertyChangedTokens dictionaries during DependencyObject construction until first write. This saves ~176 B per instance and avoids eager allocation for objects that never receive forwarded properties or property changed callbacks.
GitHub Issue: closes #24752
PR Type:
🔄 Refactoring (no functional changes, no api changes)
What changed? 🚀
Changed
_inheritedForwardedPropertiesand_propertyChangedTokensinDependencyObject.Store.csto be lazily initialized using??=. This resolves a memory allocation regression where empty dictionaries were eagerly allocated for everyDependencyObjectinstance. Added unit tests to verify the lazy initialization behavior.PR Checklist ✅
Screenshots Compare Test Runresults.