Sitelet https://github.com/unoplatform/uno/pull/18377
Skip to content

chore: Adjust Android's layouting workaround - #18377

Merged
jeromelaban merged 2 commits into
masterfrom
dev/youssef/adjust-layouting-workaround
Oct 4, 2024
Merged

chore: Adjust Android's layouting workaround#18377
jeromelaban merged 2 commits into
masterfrom
dev/youssef/adjust-layouting-workaround

Conversation

@Youssef1313

@Youssef1313 Youssef1313 commented Oct 3, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

GitHub Issue (If applicable): Related to https://github.com/unoplatform/kahua-private/issues/212

PR Type

What kind of change does this PR introduce?

What is the current behavior?

What is the new behavior?

PR Checklist

Please check if your PR fulfills the following requirements:

Other information

Internal Issue (If applicable):

@Youssef1313
Youssef1313 force-pushed the dev/youssef/adjust-layouting-workaround branch from fb5f916 to 22f8493 Compare October 3, 2024 14:58
@unodevops

unodevops commented Oct 3, 2024

Copy link
Copy Markdown
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-18377/index.html

@unodevops

unodevops commented Oct 3, 2024

Copy link
Copy Markdown
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-18377/index.html

@jeromelaban jeromelaban mentioned this pull request Oct 3, 2024
Merged
@github-actions github-actions Bot added the platform/android 🤖 Categorizes an issue or PR as relevant to the Android platform label Oct 4, 2024
@unodevops

unodevops commented Oct 4, 2024

Copy link
Copy Markdown
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-18377/index.html

@unodevops

unodevops commented Oct 4, 2024

Copy link
Copy Markdown
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-18377/index.html

@nventive-devops

nventive-devops commented Oct 4, 2024

Copy link
Copy Markdown
Contributor

The build 142172 found UI Test snapshots differences: android-28-net8: 25, android-28-net8-Snap: 53, ios: 12, ios-Snap: 195, skia-gtk-screenshots: 659, skia-linux-screenshots: 745, skia-windows-screenshots: 519, wasm: 209, wasm-automated-net9.0-UWP-Default-automated: 36, wasm-automated-net9.0-UWP-RuntimeTests-0: 0, wasm-automated-net9.0-UWP-RuntimeTests-1: 0, wasm-automated-net9.0-UWP-RuntimeTests-2: 0, wasm-automated-net9.0-WinUI-Benchmarks-automated: 0, wasm-automated-net9.0-WinUI-RuntimeTests-0: 0, wasm-automated-net9.0-WinUI-RuntimeTests-1: 0, wasm-automated-net9.0-WinUI-RuntimeTests-2: 0

Details

  • android-28-net8: 25 changed over 829

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • CommandBar_LongTitle_Validation_Uno_UI_Samples_Content_UITests_CommandBar_CommandBar_LongTitle
    • SequentialAnimations_SamplesApp_Windows_UI_Xaml_Media_Animation_SequentialAnimationsPage
    • Detereminate_ProgressRing_Validation25_[#FF0000_#008000_#FF0000_#FF0000]_Progress-Ring-Value-25
    • DecimalFormatterTest_UITests_Shared_Microsoft_UI_Xaml_Controls_NumberBoxTests_NumberBoxPage
    • ProgressRing_IsEnabled_Running_UITests_Windows_UI_Xaml_Controls_ProgressRing_WindowsProgressRing_GH1220
    • ProgressRing_Visibility_Collapsed_UITests_Windows_UI_Xaml_Controls_ProgressRing_WindowsProgressRing_GH1220
    • When_Parent_PointerMoved_After_drag_on_ScrollViewer_-_touch
    • When_NoSelectionWithItemClick_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Pointers
    • When_NoSelection_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Pointers
    • When_ExtendedSelectionWithoutItemClick_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Pointers
    • CommandBar_LongTitle_Validation_CommandBar_-_LongTitle_-_2_-_Orientation_Landscape
    • Detereminate_ProgressRing_Validation75_[#FF0000_#008000_#008000_#008000]_Progress-Ring-Value-75
    • Keyboard_Textbox_InsideScrollViewer_Validation_3_-_Remove_Focus_on_disabledTextBox
    • When_SingleSelectionWithItemClick_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Pointers
    • When_SingleSelectionWithoutItemClick_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Pointers
    • When_TextBlock_Centred_Native_Frame_UITests_Windows_UI_Xaml_Controls_CommandBar_CommandBar_Native_Frame
    • CommandBar_LongTitle_Validation_CommandBar_-_LongTitle_-_1_-_Initial_State
    • ImageStretch_None_Uno_UI_Samples_UITests_ImageTestsControl_Image_Stretch_None
    • ListView_SelectedItems_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewSelectedItems
    • When_Parent_PointerMoved_After_drag_on_non-scrolling_ScrollViewer

  • android-28-net8-Snap: 53 changed over 1066

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • ListView_ListViewScrollIntoViewSnapPoints_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewScrollIntoViewSnapPoints
    • Progress_UITests_Microsoft_UI_Xaml_Controls_ProgressBar_WinUIProgressBarSimple_UITests_Microsoft_UI_Xaml_Controls_ProgressBar_WinUIProgressBarSimple
    • NavigationView_MUXControlsTestApp_NavigationViewRS4Page_MUXControlsTestApp_NavigationViewRS4Page
    • Slider_UITests_Windows_UI_Xaml_Controls_Slider_Slider_Header_UITests_Windows_UI_Xaml_Controls_Slider_Slider_Header
    • TextBlock_TextBlockTimespan_Uno_UI_Samples_Content_UITests_TextBlockControl_TextBlockTimespan
    • MUX_NumberBox_UITests_Shared_Microsoft_UI_Xaml_Controls_NumberBoxTests_NumberBoxPage
    • Icons_UITests_Microsoft_UI_Xaml_Controls_ImageIconTests_ImageIconPage_UITests_Microsoft_UI_Xaml_Controls_ImageIconTests_ImageIconPage
    • NavigationView_MUXControlsTestApp_NavigationViewCustomThemeResourcesPage_MUXControlsTestApp_NavigationViewCustomThemeResourcesPage
    • Automation_UITests_Shared_Windows_UI_Xaml_Automation_AutomationProperties_Name_UITests_Shared_Windows_UI_Xaml_Automation_AutomationProperties_Name
    • MUX_UITests_Microsoft_UI_Xaml_Controls_SplitButtonTests_SplitButtonTestsPage_UITests_Microsoft_UI_Xaml_Controls_SplitButtonTests_SplitButtonTestsPage
    • MUX_UITests_Shared_Microsoft_UI_Xaml_Controls_TreeViewTests_TreeViewPage_UITests_Shared_Microsoft_UI_Xaml_Controls_TreeViewTests_TreeViewPage
    • Shapes_UITests_Windows_UI_Xaml_Shapes_Ellipse_Positioning_UITests_Windows_UI_Xaml_Shapes_Ellipse_Positioning
    • Shapes_UITests_Windows_UI_Xaml_Shapes_Ellipse_StrokeThickness_UITests_Windows_UI_Xaml_Shapes_Ellipse_StrokeThickness
    • TeachingTip_UITests_Microsoft_UI_Xaml_Controls_TeachingTipTests_TeachingTipPage_UITests_Microsoft_UI_Xaml_Controls_TeachingTipTests_TeachingTipPage
    • TextBlock_TextBlockMultilineInStarStackPanel_Uno_UI_Samples_Content_UITests_TextBlockControl_TextBlockMultilineInStarStackPanel
    • TextBlock_TextBlockSimpleContrainedHorizontalCenterWrap2_Uno_UI_Samples_Content_UITests_TextBlockControl_TextBlockSimpleContrainedHorizontalCenterWrap2
    • Path_UITests_Shared_Windows_UI_Xaml_Shapes_PathTestsControl_SVG_Path_UITests_Shared_Windows_UI_Xaml_Shapes_PathTestsControl_SVG_Path
    • TabView_UITests_Microsoft_UI_Xaml_Controls_TabViewTests_TabViewPage_UITests_Microsoft_UI_Xaml_Controls_TabViewTests_TabViewPage
    • MediaPlayerElement_Mini_player_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Minimal
    • Pickers_UITests_Windows_UI_Xaml_Controls_CalendarView_CalendarView_Theming_UITests_Windows_UI_Xaml_Controls_CalendarView_CalendarView_Theming

  • ios: 12 changed over 267

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • SequentialAnimations_SamplesApp_Windows_UI_Xaml_Media_Animation_SequentialAnimationsPage
    • When_ExtendedSelectionWithoutItemClick_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Pointers
    • Check_ListView_Swallows_Measure_UITests_Shared_Windows_UI_Xaml_Controls_ListView_ListView_With_ListViews_Count_Measure
    • ImageStretch_None_Uno_UI_Samples_UITests_ImageTestsControl_Image_Stretch_None
    • ListView_SelectedItems_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewSelectedItems
    • ProgressRing_Visibility_Collapsed_UITests_Windows_UI_Xaml_Controls_ProgressRing_WindowsProgressRing_GH1220
    • When_SingleSelectionWithItemClick_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Pointers
    • Check_ListView_Swallows_Measure_after_scroll
    • TextBox_UpdatedBinding_On_OneWay_Mode_UITests_Windows_UI_Xaml_Controls_TextBox_TextBox_Bindings
    • When_MultipleSelectionWithoutItemClick_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Pointers
    • When_SingleSelectionWithoutItemClick_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Pointers
    • ProgressRing_IsEnabled_Running_UITests_Windows_UI_Xaml_Controls_ProgressRing_WindowsProgressRing_GH1220

  • ios-Snap: 195 changed over 1057

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • NavigationView_MUXControlsTestApp_NavigationViewMinimalPage_MUXControlsTestApp_NavigationViewMinimalPage
    • Pointers_PointerEventArgsTests_UITests_Shared_Windows_UI_Xaml_Input_Pointers_PointerEventArgsTests
    • Pointers_Sequence_UITests_Shared_Windows_UI_Input_PointersTests_EventsSequences
    • Pointers_TappedEventTest_Uno_UI_Samples_Samples_Shared_Content_UITests_TappedEventTest
    • Pointers_TouchRotated_Uno_UI_Samples_Content_UITests_TouchEventsTests_TouchRotated
    • SwipeControl_MUXControlsTestApp_SwipeControlPage2_MUXControlsTestApp_SwipeControlPage2
    • Brushes_ImageBrushStretch_Uno_UI_Samples_UITests_ImageBrushTestControl_ImageBrushStretch
    • TextBlock_ForcedTextWithCarriageReturn_MaxLines_One_Uno_UI_Samples_Content_UITests_TextBlockControl_ForcedTextWithCarriageReturn_MaxLines_One
    • TextBlock_ForcedTextWithCarriageReturn_MaxLines_Two_Uno_UI_Samples_Content_UITests_TextBlockControl_ForcedTextWithCarriageReturn_MaxLines_Two
    • TextBlock_Progressing_TextBlock_Uno_UI_Samples_Content_UITests_TextBlockControl_Progressing_TextBlock
    • TextBlock_Progressing_TextBlock_with_inline_margin_Uno_UI_Samples_Content_UITests_TextBlockControl_Progressing_TextBlock_with_inline_margin
    • TextBlock_Progressing_TextBlock_with_margin_Uno_UI_Samples_Content_UITests_TextBlockControl_Progressing_TextBlock_with_margin
    • TextBlock_SimpleText_MaxLines_Different_Font_Size_UITests_Shared_Windows_UI_Xaml_Controls_TextBlockControl_SimpleText_MaxLines_Different_Font_Size
    • NavigationView_MUXControlsTestApp_NavigationViewBlankPage1_MUXControlsTestApp_NavigationViewBlankPage1
    • NavigationView_MUXControlsTestApp_NavigationViewIsPaneOpenPage_MUXControlsTestApp_NavigationViewIsPaneOpenPage
    • Popup_Popup_HVAlignments_Uno_UI_Samples_Content_UITests_Popup_Popup_HVAlignments
    • Popup_Popup_LightDismiss_UITests_Shared_Windows_UI_Xaml_Controls_Popup_Popup_LightDismiss
    • Popup_Popup_Simple_Uno_UI_Samples_Content_UITests_Popup_Popup_Simple
    • Progress_UITests_Microsoft_UI_Xaml_Controls_ProgressBar_WinUIProgressBarPage_UITests_Microsoft_UI_Xaml_Controls_ProgressBar_WinUIProgressBarPage
    • TextBlock_TextBlock_FontWeight_Uno_UI_Samples_Content_UITests_TextBlockControl_TextBlock_FontWeight

  • skia-gtk-screenshots: 659 changed over 2220

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • ApplicationViewSizing.png
    • BackGesture.png-dark
    • BitmapIcon_Generic.png
    • CommandBar_Native_With_Content.png-dark
    • CommandBar_Native_With_Content.png
    • DatePicker_VisualStates.png-dark
    • Flyout_Unloaded.png-dark
    • Flyout_Unloaded.png
    • NoPhase_Large.png-dark
    • NoPhase_Large.png
    • Shapes_Default_StrokeThickness.png-dark
    • Shapes_Default_StrokeThickness.png
    • TabViewItemsSourceTests.png-dark
    • TabViewItemsSourceTests.png
    • ToggleSwitchUnloadReload.png-dark
    • ToggleSwitchUnloadReload.png
    • Wasm Http Handler.png-dark
    • Wasm Http Handler.png
    • WebView2_Animated_Opacity.png-dark
    • WebView2_Animated_Opacity.png

  • skia-linux-screenshots: 745 changed over 2220

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • ApplicationViewSizing.png-dark
    • AppWindowClosing.png-dark
    • BadgeNotificationTests.png
    • BasicThemeResources.png-dark
    • BasicThemeResources.png
    • Buttons.png
    • ChatBox.png-dark
    • CloseRequestedTests.png-dark
    • ComboBox_PlaceholderText.png-dark
    • ComboBox_PlaceholderText.png
    • ContentDialog_Async.png-dark
    • ContentDialog_Async.png
    • Elevation.png-dark
    • Elevation.png
    • FlipView_Buttons.png-dark
    • FlipView_Buttons.png
    • AppWindowClosing.png
    • BenchmarkDotNet.png-dark
    • BorderWithNullBrushAndNonZeroThickness.png-dark
    • BorderWithNullBrushAndNonZeroThickness.png

  • skia-windows-screenshots: 519 changed over 2220

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • AppWindowPositionAndSize.png-dark
    • BackGesture.png
    • BadgeNotificationTests.png-dark
    • BindableDrawerLayout_ChangePane.png-dark
    • CalendarView_Theming.png-dark
    • CalendarView_Theming.png
    • CommandBar_CustomContent.png-dark
    • ContentControl_SetNull.png-dark
    • ContentControl_SetNull.png
    • DoubleAnimationClipping.png-dark
    • DoubleAnimationClipping.png
    • DoubleAnimationTestsControl.png-dark
    • Ellipse.png-dark
    • Ellipse.png
    • Application_Window lifecycle events.png
    • AutoSuggestBox_Icons.png
    • Button_IsEnabled_Automated.png-dark
    • ChatBox.png-dark
    • ContentDialog_ComboBox.png-dark
    • ContentDialog_Dialogs.png-dark

  • wasm: 209 changed over 1044

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • MUXControlsTestApp.RadialGradientBrushPage
    • MUXControlsTestApp.DropDownButtonPage
    • GenericApp.Views.Samples.Shared.Content.UITests.GridViewMultipleSelectionMode
    • MUXControlsTestApp.NavigationViewCustomThemeResourcesPage
    • initial_state
    • nVentive.Umbrella.Views.UI.Samples.Content.UITests.ButtonTestsControl.Hyperlink_CanExecute_False
    • SamplesApp.Wasm.Windows_UI_Xaml_Controls.ComboBox.ComboBox_Header
    • SamplesApp.Wasm.Windows_UI_Xaml_Controls.ComboBox.ComboBox_Picker
    • SamplesApp.Wasm.Windows_UI_Xaml_Controls.ComboBox.ComboBox_DisplayMemberPath
    • SamplesApp.Wasm.Windows_UI_Xaml_Controls.ComboBox.ComboBox_DropDownWidth
    • SamplesApp.Wasm.Windows_UI_Xaml_Controls.ComboBox.ComboBox_With_ItemTemplate
    • SamplesApp.Windows_UI_Xaml_Controls.ListView.HorizontalListView_Templates
    • SamplesApp.Windows_UI_Xaml_Controls.ListView.ListViewDynamicOrientation
    • SamplesApp.Windows_UI_Xaml.Clipping.ButtonClippingTestsControl
    • SamplesApp.Windows_UI_Xaml_Controls.ListView.ListViewSelectedItems
    • SamplesApp.Windows_UI_Xaml_Controls.ListView.ListViewWithinScollViewer
    • SamplesApp.Windows_UI_Xaml_Controls.ListView.ListView_Inside_ListView
    • SamplesApp.Windows_UI_Xaml_Controls.ListView.ListViewLegacy
    • SamplesApp.Windows_UI_Xaml_Controls.ListView.ListView_ItemClick
    • SamplesApp.Windows_UI_Xaml_Controls.ListView.ListViewMarginTest

  • wasm-automated-net9.0-UWP-Default-automated: 36 changed over 1946

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • Automation_UITests_Shared_Windows_UI_Xaml_Automation_AutomationProperties_Name_UITests_Shared_Windows_UI_Xaml_Automation_AutomationProperties_Name
    • Brushes_Uno_UI_Samples_Samples_Shared_Content_UITests_ImageBrushInList_Uno_UI_Samples_Samples_Shared_Content_UITests_ImageBrushInList
    • ListView_ListViewSelectedItems_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewSelectedItems
    • Expander_WinUIExpanderPage_UITests_Shared_Microsoft_UI_Xaml_Controls_ExpanderTests_WinUIExpanderPage
    • Default_StrokeThickness_MyPolygon
    • Default_StrokeThickness_MyPolyline
    • Default_StrokeThickness_MyRect
    • ListView_ListView_With_ListViews_Count_Measure_UITests_Shared_Windows_UI_Xaml_Controls_ListView_ListView_With_ListViews_Count_Measure
    • Default_StrokeThickness_MyPath
    • Brushes_Uno_UI_Samples_UITests_ImageBrushTestControl_ImageBrush_StreamSource_Uno_UI_Samples_UITests_ImageBrushTestControl_ImageBrush_StreamSource
    • Pickers_UITests_Windows_UI_Xaml_Controls_CalendarView_CalendarView_Theming_UITests_Windows_UI_Xaml_Controls_CalendarView_CalendarView_Theming
    • Default_Uno_UI_Samples_Content_UITests_WebView_WebView_AnchorNavigation_Uno_UI_Samples_Content_UITests_WebView_WebView_AnchorNavigation
    • Default_SamplesApp_Wasm_Windows_UI_Xaml_Controls_ListView_ListView_IsSelected_SamplesApp_Wasm_Windows_UI_Xaml_Controls_ListView_ListView_IsSelected
    • ListView_SelectedItems_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewSelectedItems
    • NavigationView_MUXControlsTestApp_NavigationViewCustomThemeResourcesPage_MUXControlsTestApp_NavigationViewCustomThemeResourcesPage
    • ToggleSwitch_IsEnabled_Validation_Uno_UI_Samples_Content_UITests_ButtonTestsControl_ToggleSwitch_IsEnable_Automated
    • When_MultipleSelectionWithoutItemClick_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Pointers
    • When_NoSelectionWithItemClick_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Pointers
    • When_NoSelection_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Pointers
    • MediaPlayerElement_Mini_player_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Minimal

  • wasm-automated-net9.0-UWP-RuntimeTests-0: 0 changed over 1

  • wasm-automated-net9.0-UWP-RuntimeTests-1: 0 changed over 1

  • wasm-automated-net9.0-UWP-RuntimeTests-2: 0 changed over 1

  • wasm-automated-net9.0-WinUI-Benchmarks-automated: 0 changed over 1

  • wasm-automated-net9.0-WinUI-RuntimeTests-0: 0 changed over 1

  • wasm-automated-net9.0-WinUI-RuntimeTests-1: 0 changed over 1

  • wasm-automated-net9.0-WinUI-RuntimeTests-2: 0 changed over 1

jeromelaban added a commit that referenced this pull request Oct 4, 2024
@jeromelaban
Merge pull request #18381 from unoplatform/dev/jela/bp-android-layout
8e7d984 
Backport #18193 and #18377
@jeromelaban
jeromelaban marked this pull request as ready for review October 4, 2024 11:34
@jeromelaban
jeromelaban merged commit 60f13a6 into master Oct 4, 2024
@jeromelaban
jeromelaban deleted the dev/youssef/adjust-layouting-workaround branch October 4, 2024 11:35
@jeromelaban jeromelaban mentioned this pull request Oct 8, 2024
Merged
@mergify mergify Bot mentioned this pull request Oct 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jeromelaban jeromelaban jeromelaban approved these changes

Assignees

No one assigned

Labels

platform/android 🤖 Categorizes an issue or PR as relevant to the Android platform

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Youssef1313 @unodevops @nventive-devops @jeromelaban