fix: Undo `ContentTemplateSelector` workarounds in Fluent styles by MartinZikmund · Pull Request #18104 · unoplatform/uno

MartinZikmund · 2024-09-03T07:41:16Z

GitHub Issue (If applicable): part of #18103

PR Type

What kind of change does this PR introduce?

Bugfix

What is the current behavior?

After #14692 it is no longer needed to add TemplateBinding for ContentTemplateSelector in fluent control templates. The workarounds being in place caused some issues - for example When_TemplateSelector_And_List_Reloaded did not pass under fluent styles.

What is the new behavior?

Workarounds removed from fluent styles.

PR Checklist

Please check if your PR fulfills the following requirements:

Docs have been added/updated which fit documentation template (for bug fixes / features)
Unit Tests and/or UI Tests for the changes have been added (for bug fixes / features) (if applicable)
Validated PR Screenshots Compare Test Run results.
Contains NO breaking changes
Associated with an issue (GitHub or internal) and uses the automatic close keywords.
Commits must be following the Conventional Commits specification.

Other information

Internal Issue (If applicable):

unodevops · 2024-09-03T08:09:04Z

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-18104/index.html

unodevops · 2024-09-03T08:18:21Z

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-18104/index.html

nventive-devops · 2024-09-03T12:05:26Z

The build 138431 found UI Test snapshots differences: android-28-net8: 23, android-28-net8-Snap: 55, ios: 6, ios-Snap: 44, skia-gtk-screenshots: 28, skia-linux-screenshots: 23, skia-windows-screenshots: 25, wasm: 361, wasm-automated-net8.0-UWP-Default-automated: 641, wasm-automated-net8.0-UWP-RuntimeTests-0: 0, wasm-automated-net8.0-UWP-RuntimeTests-1: 0, wasm-automated-net8.0-UWP-RuntimeTests-2: 0, wasm-automated-net8.0-WinUI-Benchmarks-automated: 0, wasm-automated-net8.0-WinUI-RuntimeTests-0: 0, wasm-automated-net8.0-WinUI-RuntimeTests-1: 0, wasm-automated-net8.0-WinUI-RuntimeTests-2: 0

Details

android-28-net8: 23 changed over 832
🚨🚨 Comparison Details (first 20) 🚨🚨
- Detereminate_ProgressRing_Validation75_[#FF0000_#008000_#008000_#008000]_Progress-Ring-Value-75
- TextBox_Selection_IsReadOnly_UITests_Shared_Windows_UI_Xaml_Controls_TextBoxTests_TextBox_Selection
- Detereminate_ProgressRing_Validation0_[#FF0000_#FF0000_#FF0000_#FF0000]_UITests_Microsoft_UI_Xaml_Controls_ProgressRing_WinUIDeterminateProgressRing
- ListView_ListViewVariableItemHeightLong_InitializesTest_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewVariableItemHeightLong
- NativeCommandBar_Size_Uno_UI_Samples_Content_UITests_CommandBar_CommandBar_Dynamic
- ProgressRing_Visibility_Collapsed_UITests_Windows_UI_Xaml_Controls_ProgressRing_WindowsProgressRing_GH1220
- SelectionTest_UITests_Microsoft_UI_Xaml_Controls_RadioButtonsTests_RadioButtonsPage
- SequentialAnimations_SamplesApp_Windows_UI_Xaml_Media_Animation_SequentialAnimationsPage
- When_Hardware_Back_Button_Pressed_UITests_Windows_UI_Core_SystemNavigationManagerTests_HardwareBackButton
- When_Parent_PointerMoved_After_drag_on_ScrollViewer_-_touch
- DecimalFormatterTest_UITests_Shared_Microsoft_UI_Xaml_Controls_NumberBoxTests_NumberBoxPage
- TextBox_IsReadOnly_AcceptsReturn_Test_UITests_Shared_Windows_UI_Xaml_Controls_TextBoxTests_TextBox_IsReadOnly_AcceptsReturn
- ProgressRing_IsEnabled_Running_UITests_Windows_UI_Xaml_Controls_ProgressRing_WindowsProgressRing_GH1220
- DatePicker_PickerFlyout_PlacementsbottomRight_True_False_True_UITests_Windows_UI_Xaml_Controls_DatePicker_DatePicker_Placement
- MinMaxTest_UITests_Shared_Microsoft_UI_Xaml_Controls_NumberBoxTests_NumberBoxPage
- When_FontWeight_Changed_UITests_Shared_Windows_UI_Xaml_Controls_TextBlockControl_TextBlock_FontWeight_Dynamic
- Detereminate_ProgressRing_Validation25_[#FF0000_#008000_#FF0000_#FF0000]_Progress-Ring-Value-25
- Detereminate_ProgressRing_Validation50_[#FF0000_#008000_#008000_#FF0000]_Progress-Ring-Value-50
- ListView_SelectedItems_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewSelectedItems
- ToggleCollapsedStateToVerifyClipping_UITests_Shared_Microsoft_UI_Xaml_Controls_ExpanderTests_ExpanderColorValidationPage
android-28-net8-Snap: 55 changed over 1065
🚨🚨 Comparison Details (first 20) 🚨🚨
- ListView_ListViewScrollBar_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewScrollBar
- MediaPlayerElement_Mini_player_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Minimal
- Image_ImageSourceStream_Uno_UI_Samples_UITests_ImageTestsControl_ImageSourceStream
- Default_UITests_Shared_Windows_UI_Xaml_Controls_ListView_ListView_Margin_On_Container_UITests_Shared_Windows_UI_Xaml_Controls_ListView_ListView_Margin_On_Container
- Image_UITests_Windows_UI_Xaml_Controls_ImageTests_SvgImageSource_Basic_UITests_Windows_UI_Xaml_Controls_ImageTests_SvgImageSource_Basic
- ListView_ListViewIncrementalLoading_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewIncrementalLoading
- Pickers_UITests_Windows_UI_Xaml_Controls_CalendarView_CalendarView_Theming_UITests_Windows_UI_Xaml_Controls_CalendarView_CalendarView_Theming
- TextBox_PasswordBox_AutoFill_Uno_UI_Samples_Content_UITests_TextBoxControl_PasswordBox_AutoFill
- TextBox_PasswordBox_Header_PlaceholderText_Uno_UI_Samples_Content_UITests_TextBoxControl_PasswordBox_Header_PlaceholderText
- TextBox_PasswordBox_InputScope_NumericPin_Uno_UI_Samples_Content_UITests_TextBoxControl_PasswordBox_InputScope_NumericPin
- NavigationView_MUXControlsTestApp_NavigationViewTopNavPage_MUXControlsTestApp_NavigationViewTopNavPage
- NavigationView_MUXControlsTestApp_NavigationViewRS4Page_MUXControlsTestApp_NavigationViewRS4Page
- NavigationView_MUXControlsTestApp_NavigationViewTopNavOnlyPage_MUXControlsTestApp_NavigationViewTopNavOnlyPage
- TextBox_Input_InputScope_CurrencyAmount_Uno_UI_Samples_Content_UITests_TextBoxControl_Input_InputScope_CurrencyAmount
- TextBox_Input_InputScope_Email_Uno_UI_Samples_Content_UITests_TextBoxControl_Input_InputScope_Email
- TextBox_Input_InputScope_Number_Uno_UI_Samples_Content_UITests_TextBoxControl_Input_InputScope_Number
- Flyouts_MenuFlyout_Simple_Uno_UI_Samples_Content_UITests_MenuFlyout_MenuFlyout_Simple
- TextBlock_TextBlock_LineHeight_Inlines_Uno_UI_Samples_Content_UITests_TextBlockControl_TextBlock_LineHeight_Inlines
- Gesture_Recognizer_Pointer_Events_test_bench_UITests_Shared_Windows_UI_Input_GestureRecognizer_PointersEvents
- Scrolling_MUXControlsTestApp_ScrollViewWithScrollControllersPage_MUXControlsTestApp_ScrollViewWithScrollControllersPage
ios: 6 changed over 268
🚨🚨 Comparison Details (first 20) 🚨🚨
- Check_ListView_Swallows_Measure_UITests_Shared_Windows_UI_Xaml_Controls_ListView_ListView_With_ListViews_Count_Measure
- ProgressRing_IsEnabled_Running_UITests_Windows_UI_Xaml_Controls_ProgressRing_WindowsProgressRing_GH1220
- SequentialAnimations_SamplesApp_Windows_UI_Xaml_Media_Animation_SequentialAnimationsPage
- ProgressRing_Visibility_Collapsed_UITests_Windows_UI_Xaml_Controls_ProgressRing_WindowsProgressRing_GH1220
- TextBox_UpdatedBinding_On_OneWay_Mode_UITests_Windows_UI_Xaml_Controls_TextBox_TextBox_Bindings
- When_SingleSelectionWithItemClick_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Pointers
ios-Snap: 44 changed over 1056
🚨🚨 Comparison Details (first 20) 🚨🚨
- Brushes_ImageBrushStretch2_Uno_UI_Samples_UITests_ImageBrushTestControl_ImageBrushStretch2
- ListView_ListView_With_ListViews_Count_Measure_UITests_Shared_Windows_UI_Xaml_Controls_ListView_ListView_With_ListViews_Count_Measure
- Brushes_GenericApp_Views_Content_UITests_ImageBrushTestControl_ImageBrush_UniformToFill_GenericApp_Views_Content_UITests_ImageBrushTestControl_ImageBrush_UniformToFill
- Brushes_PathImageBrushfill_Uno_UI_Samples_UITests_ImageBrushTestControl_PathImageBrushfill
- Brushes_ImageBrushAlignmentXY_Uno_UI_Samples_UITests_ImageBrushTestControl_ImageBrushAlignmentXY
- ContentControl_ContentControl_Nested_TemplatedParent_Uno_UI_Samples_Content_UITests_ContentControlTestsControl_ContentControl_Nested_TemplatedParent
- Brushes_Uno_UI_Samples_Samples_Shared_Content_UITests_ImageBrushInList_Uno_UI_Samples_Samples_Shared_Content_UITests_ImageBrushInList
- Buttons_Custom_Button_With_ContentTemplate_Uno_UI_Samples_Content_UITests_ButtonTestsControl_Custom_Button_With_ContentTemplate
- Default_Uno_UI_Samples_Content_UITests_WebView_WebView_AnchorNavigation_Uno_UI_Samples_Content_UITests_WebView_WebView_AnchorNavigation
- Image_Uno_UI_Samples_UITests_Image_Image_Stretch_Alignment_Smaller_Uno_UI_Samples_UITests_Image_Image_Stretch_Alignment_Smaller
- Image_Uno_UI_Samples_UITests_Image_Image_Stretch_Alignment_Taller_Uno_UI_Samples_UITests_Image_Image_Stretch_Alignment_Taller
- Image_Uno_UI_Samples_UITests_Image_Image_Stretch_Alignment_Wider_Uno_UI_Samples_UITests_Image_Image_Stretch_Alignment_Wider
- ListView_HorizontalListViewGrouped_SamplesApp_Windows_UI_Xaml_Controls_ListView_HorizontalListViewGrouped
- Image_UITests_Windows_UI_Xaml_Controls_ImageTests_Image_Formats_UITests_Windows_UI_Xaml_Controls_ImageTests_Image_Formats
- NavigationView_FluentStyle_NavigationViewSample_SamplesApp_Samples_Microsoft_UI_Xaml_Controls_NavigationViewTests_FluentStyle_FluentStyle_NavigationViewSample
- TextBlock_Attributed_text_FontSize_Changing_Uno_UI_Samples_Content_UITests_TextBlockControl_Attributed_text_FontSize_Changing
- SwipeControl_MUXControlsTestApp_SwipeControlPage2_MUXControlsTestApp_SwipeControlPage2
- Image_UITests_Shared_Windows_UI_Xaml_Controls_ImageTests_Image_Stretch_Algmnt_Inf_Vertical_UITests_Shared_Windows_UI_Xaml_Controls_ImageTests_Image_Stretch_Algmnt_Inf_Vertical
- Image_ImageSourceStream_Uno_UI_Samples_UITests_ImageTestsControl_ImageSourceStream
- Image_Uno_UI_Samples_UITests_Image_Image_Stretch_Alignment_Bigger_Uno_UI_Samples_UITests_Image_Image_Stretch_Alignment_Bigger
skia-gtk-screenshots: 28 changed over 2216
🚨🚨 Comparison Details (first 20) 🚨🚨
- Window_SetBackground.png-dark
- Window_SetBackground.png
- CalendarView_Theming.png-dark
- CalendarView_Theming.png
- ImageBrushAlignmentXY.png
- PasswordBox_AutoFill.png-dark
- PasswordBox_AutoFill.png
- ImageOpened.png
- UIElement_ContextFlyout.png-dark
- UIElement_ContextFlyout.png
- TransformToVisual_Simple.png-dark
- TransformToVisual_Simple.png
- Mini player.png-dark
- Mini player.png
- Path_Geometries.png-dark
- Path_Geometries.png
- PanelImageBrush.png-dark
- PanelImageBrush.png
- RectanglemaskingRectangleGrid.png
- ImageBrush_UniformToFill.png
skia-linux-screenshots: 23 changed over 2216
🚨🚨 Comparison Details (first 20) 🚨🚨
- ImageIconPage.png-dark
- ImageIconPage.png
- BorderImageBrushRelativeTransform.png-dark
- BorderImageBrushRelativeTransform.png
- Image_UseTargetSize.png-dark
- Image_UseTargetSize.png
- CalendarView_Theming.png
- ImageBrushStretch.png-dark
- ImageBrushStretch.png
- CalendarView_Theming.png-dark
- Ellipse.png-dark
- Ellipse.png
- Mini player.png-dark
- Mini player.png
- ListView_Weird_Measure.png-dark
- ListView_Weird_Measure.png
- PanelImageBrush.png-dark
- PanelImageBrush.png
- Using .ogg.png-dark
- Using .ogg.png
skia-windows-screenshots: 25 changed over 2216
🚨🚨 Comparison Details (first 20) 🚨🚨
- AppWindowPositionAndSize.png
- AppWindowPositionAndSize.png-dark
- BorderImageBrush.png-dark
- BorderImageBrush.png
- CalendarView_Theming.png-dark
- CalendarView_Theming.png
- Ellipse.png-dark
- Ellipse.png
- ImageSourceUrlMsAppDataScheme.png-dark
- ImageSourceUrlMsAppDataScheme.png
- Image_UseTargetSize.png-dark
- Image_UseTargetSize.png
- DoubleImageBrushInList.png-dark
- DoubleImageBrushInList.png
- ImageInStackPanel.png-dark
- ImageInStackPanel.png
- Uniform100x100.png-dark
- Uniform100x100.png
- Mini player.png-dark
- Mini player.png
wasm: 361 changed over 1043
🚨🚨 Comparison Details (first 20) 🚨🚨
- MUXControlsTestApp.PipsPagerPage
- MUXControlsTestApp.RefreshVisualizerPage
- SamplesApp.Microsoft_UI_Xaml_Controls.WebView2Tests.WebView2_WithHeaders
- SamplesApp.Wasm.Windows_UI_Xaml_Media.Transform.Border_With_Off_Centre_RotateTransform
- SamplesApp.Windows_UI_Xaml_Controls.ListView.ListViewGrouped_ItemContainerStyleSelector
- SamplesApp.Windows_UI_Xaml_Controls.ListView.ListViewHeaderFooterOnly
- SamplesApp.Windows_UI_Xaml_Controls.ListView.ListView_Expandable_Item_Large
- SamplesApp.Windows_UI_Xaml_Shapes.ShapeControlsPage
- UITests.Shared.Windows_Phone.Devices_Notifications_VibrationDevice
- UITests.Shared.Windows_UI_Xaml.WebView2_Alert
- UITests.Shared.Windows_UI_Xaml_Controls.FlyoutTests.Flyout_Vanilla
- UITests.Shared.Windows_UI_Xaml_Controls.TextBoxTests.TextBox_Formatting_Flicker
- UITests.Shared.Windows_UI_Xaml_Controls.TextBoxTests.TextBox_IsReadOnly_AcceptsReturn
- UITests.Shared.Windows_UI_Xaml_Controls.TextBoxTests.TextBox_MaxLength
- UITests.Windows_Gaming.GamepadEnumerationTest
- UITests.Windows_UI_Xaml.xLoadTests.xLoad_xBind
- UITests.Windows_UI_Xaml_Controls.ImageTests.SvgImageSource_NoSize
- UITests.Windows_UI_Xaml_Controls.ImageTests.WriteableBitmap_MultiInvalidate
- UITests.Windows_UI_Xaml_Controls.ItemsControl.ItemsControl_ItemContainerStyle
- Benchmarks.Shared.Controls.BenchmarkDotNetTestsPage
wasm-automated-net8.0-UWP-Default-automated: 641 changed over 1952
🚨🚨 Comparison Details (first 20) 🚨🚨
- Automation_AutomationProperties_AutomationId_UITests_Shared_Windows_UI_Xaml_Automation_AutomationProperties_AutomationId
- BitmapImage_vs_SvgImageSource_BitmapLocal_UITests_Windows_UI_Xaml_Controls_ImageTests_BitmapImage_vs_SvgImageSource
- Border_CornerRadius_BorderThickness_Border-CornerRadius-10-BorderThickness-10_0_10_10
- Border_CornerRadius_BorderThickness_Border-CornerRadius-10-BorderThickness-10_10_10_10
- Border_UITests_Windows_UI_Xaml_Controls_BorderTests_Border_LinearGradientBrush_UITests_Windows_UI_Xaml_Controls_BorderTests_Border_LinearGradientBrush
- Default_SamplesApp_Wasm_Windows_UI_Xaml_Controls_ListView_ListView_IsSelected_SamplesApp_Wasm_Windows_UI_Xaml_Controls_ListView_ListView_IsSelected
- FocusManager_GetFocusedElement_Grid_Validation_Uno_UI_Samples_Content_UITests_FocusTests_FocusManager_GetFocus_Automated
- Gesture_Recognizer_VisualStates_Buttons_UITests_Shared_Windows_UI_Input_VisualStatesTests_Buttons
- Gesture_Recognizer_VisualStates_GridViewItem_UITests_Shared_Windows_UI_Input_VisualStatesTests_GridViewItem
- Gesture_Recognizer_VisualStates_TextBox_UITests_Shared_Windows_UI_Input_VisualStatesTests_TextBox_VisualStates
- InputScope_Should_Not_Validate_Input_Uno_UI_Samples_Content_UITests_TextBoxControl_Input_InputScope_CurrencyAmount
- AutoSuggestBox_UITests_Shared_Windows_UI_Xaml_Controls_AutoSuggestBoxTests_AutoSuggestBox_Keyboard_UITests_Shared_Windows_UI_Xaml_Controls_AutoSuggestBoxTests_AutoSuggestBox_Keyboard
- Border_CornerRadius_BorderThickness_Border-CornerRadius-10-BorderThickness-0_0_0_0
- Border_CornerRadius_BorderThickness_Border-CornerRadius-10-BorderThickness-10_0_0_0
- Brushes_RadialGradientBrush_MUXControlsTestApp_RadialGradientBrushPage
- Check_CornerRadius_Border_Basic_sample
- DatePicker_Flyout_DatePicker_-_Flyout
- FocusManager_GetFocusedElement_ComboBox_LostFocus_Validation_Uno_UI_Samples_Content_UITests_FocusTests_FocusManager_GetFocus_Automated
- FocusManager_GetFocusedElement_ComboBox_Validation_FocusManager_-_GetFocusedElement_-_ComboBox_-_2_-_After_Selection
- Image_UITests_Windows_UI_Xaml_Controls_ImageTests_Image_Formats_UITests_Windows_UI_Xaml_Controls_ImageTests_Image_Formats
wasm-automated-net8.0-UWP-RuntimeTests-0: 0 changed over 1
wasm-automated-net8.0-UWP-RuntimeTests-1: 0 changed over 1
wasm-automated-net8.0-UWP-RuntimeTests-2: 0 changed over 1
wasm-automated-net8.0-WinUI-Benchmarks-automated: 0 changed over 1
wasm-automated-net8.0-WinUI-RuntimeTests-0: 0 changed over 1
wasm-automated-net8.0-WinUI-RuntimeTests-1: 0 changed over 1
wasm-automated-net8.0-WinUI-RuntimeTests-2: 0 changed over 1

nventive-devops · 2024-09-03T14:54:18Z

The build 138431 found UI Test snapshots differences: android-28-net8: 23, android-28-net8-Snap: 55, ios: 6, ios-Snap: 44, skia-gtk-screenshots: 28, skia-linux-screenshots: 23, skia-windows-screenshots: 25, wasm: 361, wasm-automated-net8.0-UWP-Default-automated: 641, wasm-automated-net8.0-UWP-RuntimeTests-0: 0, wasm-automated-net8.0-UWP-RuntimeTests-1: 0, wasm-automated-net8.0-UWP-RuntimeTests-2: 0, wasm-automated-net8.0-WinUI-Benchmarks-automated: 0, wasm-automated-net8.0-WinUI-RuntimeTests-0: 0, wasm-automated-net8.0-WinUI-RuntimeTests-1: 0, wasm-automated-net8.0-WinUI-RuntimeTests-2: 0

Details

android-28-net8: 23 changed over 832
🚨🚨 Comparison Details (first 20) 🚨🚨
- Detereminate_ProgressRing_Validation0_[#FF0000_#FF0000_#FF0000_#FF0000]_UITests_Microsoft_UI_Xaml_Controls_ProgressRing_WinUIDeterminateProgressRing
- When_FontWeight_Changed_UITests_Shared_Windows_UI_Xaml_Controls_TextBlockControl_TextBlock_FontWeight_Dynamic
- DecimalFormatterTest_UITests_Shared_Microsoft_UI_Xaml_Controls_NumberBoxTests_NumberBoxPage
- ProgressRing_IsEnabled_Running_UITests_Windows_UI_Xaml_Controls_ProgressRing_WindowsProgressRing_GH1220
- ProgressRing_Visibility_Collapsed_UITests_Windows_UI_Xaml_Controls_ProgressRing_WindowsProgressRing_GH1220
- SelectionTest_UITests_Microsoft_UI_Xaml_Controls_RadioButtonsTests_RadioButtonsPage
- NativeCommandBar_Size_Uno_UI_Samples_Content_UITests_CommandBar_CommandBar_Dynamic
- SequentialAnimations_SamplesApp_Windows_UI_Xaml_Media_Animation_SequentialAnimationsPage
- ListView_SelectedItems_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewSelectedItems
- ToggleCollapsedStateToVerifyClipping_UITests_Shared_Microsoft_UI_Xaml_Controls_ExpanderTests_ExpanderColorValidationPage
- TextBox_IsReadOnly_AcceptsReturn_Test_UITests_Shared_Windows_UI_Xaml_Controls_TextBoxTests_TextBox_IsReadOnly_AcceptsReturn
- When_Parent_PointerMoved_After_drag_on_ScrollViewer_-_touch
- Detereminate_ProgressRing_Validation50_[#FF0000_#008000_#008000_#FF0000]_Progress-Ring-Value-50
- MinMaxTest_UITests_Shared_Microsoft_UI_Xaml_Controls_NumberBoxTests_NumberBoxPage
- Detereminate_ProgressRing_Validation25_[#FF0000_#008000_#FF0000_#FF0000]_Progress-Ring-Value-25
- TextBox_Selection_IsReadOnly_UITests_Shared_Windows_UI_Xaml_Controls_TextBoxTests_TextBox_Selection
- When_Hardware_Back_Button_Pressed_UITests_Windows_UI_Core_SystemNavigationManagerTests_HardwareBackButton
- DatePicker_PickerFlyout_PlacementsbottomRight_True_False_True_UITests_Windows_UI_Xaml_Controls_DatePicker_DatePicker_Placement
- Detereminate_ProgressRing_Validation75_[#FF0000_#008000_#008000_#008000]_Progress-Ring-Value-75
- WebView_NavigateToLongString_AfterSuccess
android-28-net8-Snap: 55 changed over 1065
🚨🚨 Comparison Details (first 20) 🚨🚨
- Image_UITests_Windows_UI_Xaml_Controls_ImageTests_SvgImageSource_Basic_UITests_Windows_UI_Xaml_Controls_ImageTests_SvgImageSource_Basic
- MUX_UITests_Shared_Microsoft_UI_Xaml_Controls_TreeViewTests_TreeViewPage_UITests_Shared_Microsoft_UI_Xaml_Controls_TreeViewTests_TreeViewPage
- TextBox_PasswordBox_AutoFill_Uno_UI_Samples_Content_UITests_TextBoxControl_PasswordBox_AutoFill
- Buttons_UITests_Microsoft_UI_Xaml_Controls_RadioButtonsTests_RadioButtonsPage_UITests_Microsoft_UI_Xaml_Controls_RadioButtonsTests_RadioButtonsPage
- Microsoft_UI_Composition_UITests_Windows_UI_Composition_Vector3KeyFrameAnimationSample_UITests_Windows_UI_Composition_Vector3KeyFrameAnimationSample
- TextBox_PasswordBox_Header_PlaceholderText_Uno_UI_Samples_Content_UITests_TextBoxControl_PasswordBox_Header_PlaceholderText
- TextBox_PasswordBox_InputScope_NumericPin_Uno_UI_Samples_Content_UITests_TextBoxControl_PasswordBox_InputScope_NumericPin
- TextBlock_TextBlock_Inlines_TemplatedParent_Uno_UI_Samples_Content_UITests_TextBlockControl_TextBlock_Inlines_TemplatedParent
- MediaPlayerElement_Sources_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Sources
- MediaPlayerElement_Using_3gp_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_3gp_Extension
- MediaPlayerElement_Using_mp3_Audio_only_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Mp3_Extension
- MediaPlayerElement_Using_ogg_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Ogg_Extension
- Gesture_Recognizer_UITests_Shared_Windows_UI_Input_GestureRecognizerTests_Manipulation_Basics_UITests_Shared_Windows_UI_Input_GestureRecognizerTests_Manipulation_Basics
- Gesture_Recognizer_Pointer_Events_test_bench_UITests_Shared_Windows_UI_Input_GestureRecognizer_PointersEvents
- Info_UITests_Microsoft_UI_Xaml_Controls_InfoBadgeTests_InfoBadgePage_UITests_Microsoft_UI_Xaml_Controls_InfoBadgeTests_InfoBadgePage
- ToggleSwitch_ToggleSwitch_Header_UITests_Shared_Windows_UI_Xaml_Controls_ToggleSwitchControl_ToggleSwitch_Header
- ToggleSwitch_ToggleSwitch_IsOn_SamplesApp_Windows_UI_Xaml_Controls_ToggleSwitchControl_ToggleSwitch_IsOn
- TextBox_UITests_Shared_Windows_UI_Xaml_Controls_TextBoxTests_TextBox_IsReadOnly_AcceptsReturn_UITests_Shared_Windows_UI_Xaml_Controls_TextBoxTests_TextBox_IsReadOnly_AcceptsReturn
- Focus_FocusManagerTest_Uno_UI_Samples_Content_UITests_FocusTests_FocusManagerTest
- TextBox_UITests_Shared_Windows_UI_Xaml_Controls_TextBoxTests_TextBox_Selection_UITests_Shared_Windows_UI_Xaml_Controls_TextBoxTests_TextBox_Selection
ios: 6 changed over 268
🚨🚨 Comparison Details (first 20) 🚨🚨
- SequentialAnimations_SamplesApp_Windows_UI_Xaml_Media_Animation_SequentialAnimationsPage
- TextBox_UpdatedBinding_On_OneWay_Mode_UITests_Windows_UI_Xaml_Controls_TextBox_TextBox_Bindings
- ProgressRing_Visibility_Collapsed_UITests_Windows_UI_Xaml_Controls_ProgressRing_WindowsProgressRing_GH1220
- Check_ListView_Swallows_Measure_UITests_Shared_Windows_UI_Xaml_Controls_ListView_ListView_With_ListViews_Count_Measure
- ProgressRing_IsEnabled_Running_UITests_Windows_UI_Xaml_Controls_ProgressRing_WindowsProgressRing_GH1220
- When_SingleSelectionWithItemClick_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Pointers
ios-Snap: 44 changed over 1056
🚨🚨 Comparison Details (first 20) 🚨🚨
- ListView_HorizontalListViewGrouped_SamplesApp_Windows_UI_Xaml_Controls_ListView_HorizontalListViewGrouped
- Shapes_UITests_Windows_UI_Xaml_Shapes_Ellipse_StrokeThickness_UITests_Windows_UI_Xaml_Shapes_Ellipse_StrokeThickness
- Brushes_EllipsemaskingEllipseGrid_Uno_UI_Samples_UITests_ImageBrushTestControl_EllipsemaskingEllipseGrid
- ListView_ListViewGrouped_ItemContainerStyleSelector_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewGrouped_ItemContainerStyleSelector
- TextBlock_TextBlockMultilineInStarStackPanel_Uno_UI_Samples_Content_UITests_TextBlockControl_TextBlockMultilineInStarStackPanel
- Brushes_PathImageBrushfill_Uno_UI_Samples_UITests_ImageBrushTestControl_PathImageBrushfill
- Default_Uno_UI_Samples_Content_UITests_WebView_WebView_AnchorNavigation_Uno_UI_Samples_Content_UITests_WebView_WebView_AnchorNavigation
- Image_Image_Stretch_None_ScrollViewer_Uno_UI_Samples_UITests_ImageTestsControl_Image_Stretch_None_Containers
- Brushes_GenericApp_Views_Content_UITests_ImageBrushTestControl_ImageBrush_UniformToFill_GenericApp_Views_Content_UITests_ImageBrushTestControl_ImageBrush_UniformToFill
- Brushes_BorderImageBrush_Uno_UI_Samples_UITests_ImageBrushTestControl_BorderImageBrush
- Brushes_Uno_UI_Samples_Samples_Shared_Content_UITests_ImageBrushInList_Uno_UI_Samples_Samples_Shared_Content_UITests_ImageBrushInList
- Image_ImageSourceStream_Uno_UI_Samples_UITests_ImageTestsControl_ImageSourceStream
- Image_UITests_Shared_Windows_UI_Xaml_Controls_ImageTests_Image_Stretch_Algmnt_Inf_Horizontal_UITests_Shared_Windows_UI_Xaml_Controls_ImageTests_Image_Stretch_Algmnt_Inf_Horizontal
- Image_UITests_Shared_Windows_UI_Xaml_Controls_ImageTests_Image_Stretch_Algmnt_Inf_Vertical_UITests_Shared_Windows_UI_Xaml_Controls_ImageTests_Image_Stretch_Algmnt_Inf_Vertical
- Image_Uno_UI_Samples_UITests_Image_Image_Stretch_Alignment_Bigger_Uno_UI_Samples_UITests_Image_Image_Stretch_Alignment_Bigger
- Image_Uno_UI_Samples_UITests_Image_Image_Stretch_Alignment_Equal_Uno_UI_Samples_UITests_Image_Image_Stretch_Alignment_Equal
- NavigationView_FluentStyle_NavigationViewSample_SamplesApp_Samples_Microsoft_UI_Xaml_Controls_NavigationViewTests_FluentStyle_FluentStyle_NavigationViewSample
- ListView_ListView_Image_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListView_Image
- SwipeControl_MUXControlsTestApp_SwipeControlPage2_MUXControlsTestApp_SwipeControlPage2
- Icons_UITests_Shared_Windows_UI_Xaml_Controls_BitmapIconTests_BitmapIcon_Foreground_UITests_Shared_Windows_UI_Xaml_Controls_BitmapIconTests_BitmapIcon_Foreground
skia-gtk-screenshots: 28 changed over 2216
🚨🚨 Comparison Details (first 20) 🚨🚨
- CalendarView_Theming.png
- CalendarView_Theming.png-dark
- Mini player.png-dark
- Mini player.png
- Path_Geometries.png-dark
- Path_Geometries.png
- UIElement_ContextFlyout.png-dark
- UIElement_ContextFlyout.png
- Window_SetBackground.png-dark
- Window_SetBackground.png
- ImageOpened.png
- TransformToVisual_Simple.png-dark
- TransformToVisual_Simple.png
- ImageBrushAlignmentXY.png
- PasswordBox_AutoFill.png-dark
- PasswordBox_AutoFill.png
- PanelImageBrush.png-dark
- PanelImageBrush.png
- Native.png-dark
- Native.png
skia-linux-screenshots: 23 changed over 2216
🚨🚨 Comparison Details (first 20) 🚨🚨
- CalendarView_Theming.png
- BorderImageBrushRelativeTransform.png
- CalendarView_Theming.png-dark
- Ellipse.png-dark
- Ellipse.png
- BorderImageBrushRelativeTransform.png-dark
- ImageBrushStretch.png-dark
- ImageBrushStretch.png
- ImageIconPage.png-dark
- ImageIconPage.png
- Image_UseTargetSize.png-dark
- Image_UseTargetSize.png
- ListView_Weird_Measure.png-dark
- ListView_Weird_Measure.png
- SvgImageSource_Icons.png
- Mini player.png-dark
- Mini player.png
- PanelImageBrush.png-dark
- PanelImageBrush.png
- Using .ogg.png-dark
skia-windows-screenshots: 25 changed over 2216
🚨🚨 Comparison Details (first 20) 🚨🚨
- Ellipse.png-dark
- Ellipse.png
- AppWindowPositionAndSize.png-dark
- AppWindowPositionAndSize.png
- BorderImageBrush.png-dark
- ImageSourceUrlMsAppDataScheme.png-dark
- ImageSourceUrlMsAppDataScheme.png
- Image_UseTargetSize.png-dark
- Image_UseTargetSize.png
- BorderImageBrush.png
- ImageInStackPanel.png-dark
- ImageInStackPanel.png
- CalendarView_Theming.png
- DoubleImageBrushInList.png-dark
- DoubleImageBrushInList.png
- CalendarView_Theming.png-dark
- Mini player.png-dark
- Mini player.png
- SvgImageSource_Icons.png
- Uniform100x100.png-dark
wasm: 361 changed over 1043
🚨🚨 Comparison Details (first 20) 🚨🚨
- Benchmarks.Shared.Controls.BenchmarkDotNetTestsPage
- MUXControlsTestApp.NavigationViewItemTemplatePage
- MUXControlsTestApp.NavigationViewMenuItemStretchPage
- MUXControlsTestApp.NavigationViewTopNavPage
- SamplesApp.Wasm.Windows_UI_Xaml_Media.Transform.TransformToVisual_Simple
- SamplesApp.Windows_UI_Xaml_Controls.ListView.ListViewChangeViewArbitrary
- SamplesApp.Windows_UI_Xaml_Controls.ListView.ListViewLegacy
- SamplesApp.Windows_UI_Xaml_Controls.ListView.ListView_SelectedItem
- SamplesApp.Windows_UI_Xaml_Shapes.PathTestsControl.StretchUniform
- UITests.Microsoft_UI_Xaml_Controls.ImageIconTests.ImageIconPage
- UITests.Microsoft_UI_Xaml_Controls.WebView2Tests.WebView2_NavigationProperties
- UITests.Shared.Windows_UI_Xaml.FrameworkElementTests.FrameworkElement_UnloadedMeasure
- UITests.Shared.Windows_UI_Xaml.FrameworkElementTests.ItemsControl_Loaded
- UITests.Shared.Windows_UI_Xaml.FrameworkElementTests.LoadEvents
- UITests.Shared.Windows_UI_Xaml.FrameworkElementTests.XamlEvent_Leak
- UITests.Shared.Windows_UI_Xaml_Controls.ScrollViewerTests.ScrollViewer_Content_Smaller_Than_Viewport
- UITests.Windows_UI_Xaml.FrameworkElementTests.FrameworkElement_Opacity
- UITests.Windows_UI_Xaml_Controls.ImageTests.Image_Transforms
- UITests.Windows_UI_Xaml_Controls.SwipeControlTests.SwipeControl_ScrollViewer
- UITests.Windows_UI_Xaml_Controls.SymbolIconTests.SymbolIcon_Generic
wasm-automated-net8.0-UWP-Default-automated: 641 changed over 1952
🚨🚨 Comparison Details (first 20) 🚨🚨
- AutoSuggestBox_UITests_Shared_Windows_UI_Xaml_Controls_AutoSuggestBoxTests_BasicAutoSuggestBox_UITests_Shared_Windows_UI_Xaml_Controls_AutoSuggestBoxTests_BasicAutoSuggestBox
- BitmapImage_vs_SvgImageSource_BitmapRemote_UITests_Windows_UI_Xaml_Controls_ImageTests_BitmapImage_vs_SvgImageSource
- Check_CornerRadius_Border_Basic_sample
- Flyouts_UITests_Shared_Windows_UI_Xaml_Controls_Flyout_Flyout_OverlayInputPassThroughElement_UITests_Shared_Windows_UI_Xaml_Controls_Flyout_Flyout_OverlayInputPassThroughElement
- FocusManager_GetFocusedElement_Rectangle_Validation_Uno_UI_Samples_Content_UITests_FocusTests_FocusManager_GetFocus_Automated
- GridView_GenericApp_Views_Samples_Shared_Content_UITests_GridViewMultipleSelectionMode_GenericApp_Views_Samples_Shared_Content_UITests_GridViewMultipleSelectionMode
- Image_Image_Stretch_Full_Taller_Uno_UI_Samples_UITests_Image_Image_Stretch_Full_Taller
- ListView_ObservableCollection_Creation_Count_Scrolled2
- AutoSuggestBox_UITests_Shared_Windows_UI_Xaml_Controls_AutoSuggestBoxTests_AutoSuggestBoxChosenSuggestion_UITests_Shared_Windows_UI_Xaml_Controls_AutoSuggestBoxTests_AutoSuggestBoxChosenSuggestion
- Clipping_UITests_Windows_UI_Xaml_Clipping_BorderVisualClipping_UITests_Windows_UI_Xaml_Clipping_BorderVisualClipping
- Default_UITests_Toolkit_ElevatedView_CornerRadius_UITests_Toolkit_ElevatedView_CornerRadius
- Expander_WinUIExpanderPage_UITests_Shared_Microsoft_UI_Xaml_Controls_ExpanderTests_WinUIExpanderPage
- FocusManager_FocusDirection_Right_Validation_Uno_UI_Samples_Content_UITests_FocusTests_FocusManager_FocusDirection
- FocusManager_FocusDirection_Up_Validation_Uno_UI_Samples_Content_UITests_FocusTests_FocusManager_FocusDirection
- ListView_UITests_Windows_UI_Xaml_Controls_ListView_ListViewItem_IsEnabled_UITests_Windows_UI_Xaml_Controls_ListView_ListViewItem_IsEnabled
- ListView_UITests_Windows_UI_Xaml_Controls_ListView_ListView_DisplayMemberPath_UITests_Windows_UI_Xaml_Controls_ListView_ListView_DisplayMemberPath
- Buttons_ToggleSwitch_IsEnable_Automated_Uno_UI_Samples_Content_UITests_ButtonTestsControl_ToggleSwitch_IsEnable_Automated
- Buttons_UITests_Microsoft_UI_Xaml_Controls_RadioButtonsTests_RadioButtonsBasicPage_UITests_Microsoft_UI_Xaml_Controls_RadioButtonsTests_RadioButtonsBasicPage
- Clipping_SamplesApp_Windows_UI_Xaml_Clipping_ButtonClippingTestsControl_SamplesApp_Windows_UI_Xaml_Clipping_ButtonClippingTestsControl
- ContentControl_ContentControl_Changing_ContentTemplate_Uno_UI_Samples_Content_UITests_ContentControlTestsControl_ContentControl_Changing_ContentTemplate
wasm-automated-net8.0-UWP-RuntimeTests-0: 0 changed over 1
wasm-automated-net8.0-UWP-RuntimeTests-1: 0 changed over 1
wasm-automated-net8.0-UWP-RuntimeTests-2: 0 changed over 1
wasm-automated-net8.0-WinUI-Benchmarks-automated: 0 changed over 1
wasm-automated-net8.0-WinUI-RuntimeTests-0: 0 changed over 1
wasm-automated-net8.0-WinUI-RuntimeTests-1: 0 changed over 1
wasm-automated-net8.0-WinUI-RuntimeTests-2: 0 changed over 1

MartinZikmund added 3 commits September 3, 2024 09:34

fix: Undo ContentTemplateSelector workarounds in Fluent styles

d4de0f9

chore: Update merged styles

0ac0327

test: Validate fluent template selector in ListView

15fc6b0

MartinZikmund changed the title ~~fix: Undo ContentTemplateSelector workarounds in Fluent styles~~ fix: Undo ContentTemplateSelector workarounds in Fluent styles Sep 3, 2024

MartinZikmund requested review from Youssef1313 and ramezgerges September 3, 2024 07:43

MartinZikmund enabled auto-merge September 3, 2024 07:43

Youssef1313 approved these changes Sep 3, 2024

View reviewed changes

MartinZikmund merged commit 2b54112 into master Sep 3, 2024

MartinZikmund deleted the dev/mazi/contenttemplateselector branch September 3, 2024 15:03

Navigation Menu

Repository navigation

fix: Undo `ContentTemplateSelector` workarounds in Fluent styles - #18104

fix: Undo `ContentTemplateSelector` workarounds in Fluent styles#18104
MartinZikmund merged 3 commits into
masterfrom
dev/mazi/contenttemplateselector

MartinZikmund commented Sep 3, 2024

Uh oh!

unodevops commented Sep 3, 2024

Uh oh!

unodevops commented Sep 3, 2024

Uh oh!

nventive-devops commented Sep 3, 2024

Uh oh!

nventive-devops commented Sep 3, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

MartinZikmund commented Sep 3, 2024

PR Type

What is the current behavior?

What is the new behavior?

PR Checklist

Other information

Uh oh!

unodevops commented Sep 3, 2024

Uh oh!

unodevops commented Sep 3, 2024

Uh oh!

nventive-devops commented Sep 3, 2024

Uh oh!

nventive-devops commented Sep 3, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants