Repository navigation
Conversation
halibobo1205
requested review from
317787106,
waynercheung and
yanghang8612
September 23, 2026 11:14
317787106
approved these changes
Sep 24, 2026
yanghang8612
approved these changes
Sep 24, 2026
Little-Peony
added a commit
to Little-Peony/java-tron
that referenced
this pull request
Oct 9, 2026
* release_v4.8.3: refactor(framework): decouple Manager from TronJsonRpcImpl (tronprotocol#6990) refactor(api): replace response copy wrappers with Jetty content count (tronprotocol#6982) update a new version. version name:GreatVoyage-v4.8.2.2-1-gf3e81404fe,version code:18830 (tronprotocol#7008) feat: improve node stability and execution efficiency (tronprotocol#7007) chore(p2p): internalize libp2p v2.2.9 as a local `p2p` module (tronprotocol#6992) refactor(vm): remove unreachable trace compression path (tronprotocol#6997) fix(test): isolate cross-test state leaks and stabilize flaky suites (tronprotocol#6974) refactor(config): improve startup errors and remove inactive assertions (tronprotocol#6960) ci: optimize pull request checks (tronprotocol#6938) fix(config): remove inactive RocksDB options (tronprotocol#6944) # Conflicts: # framework/src/main/java/org/tron/core/services/http/servlets/CreateShieldedTransactionWithoutSpendAuthSigServlet.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Remove the unreachable VM trace compression path:
VMConfig.vmTraceCompressedand its getter.VMActuator.VMUtils.zipAndEncode(), bothcompress()overloads, the private stream-copy helper,BUF_SIZE, and unused imports.Why are these changes required?
vmTraceCompressedis permanentlyfalse, has no setter, and is not exposed throughVmConfigorreference.conf. Its only read site guards the sole entry point into the compression helpers, leaving the entire path unreachable.Removing this code reduces maintenance overhead and eliminates an unused compression implementation with incomplete
Deflaterresource cleanup.This PR has been tested by:
git diff --checkpassed.Follow up
None.
Extra details
None.