Sitelet https://github.com/transparency-dev/formats/pull/66
Skip to content

Migrate signers - #66

Merged
AlCutter merged 3 commits into
transparency-dev:mainfrom
AlCutter:migrate_signers
Dec 5, 2023
Merged

Migrate signers#66
AlCutter merged 3 commits into
transparency-dev:mainfrom
AlCutter:migrate_signers

Conversation

@AlCutter

@AlCutter AlCutter commented Dec 5, 2023 •
edited
Loading

Copy link
Copy Markdown
Collaborator

This PR migrates the note signer/verifier implementations from transparency-dev/witness/internal/note with a small tweak to the API to use the embedded alg field in the pubkey.

@AlCutter
AlCutter requested a review from a team as a code owner December 5, 2023 16:51
@AlCutter
AlCutter requested a review from roger2hk December 5, 2023 16:51
@codecov

codecov Bot commented Dec 5, 2023 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Attention: 42 lines in your changes are missing coverage. Please review.

Comparison is base (79a89ae) 100.00% compared to head (210e760) 81.73%.
Report is 1 commits behind head on main.

Files Patch % Lines
note/note_cosigv1.go 74.07% 20 Missing and 8 partials ⚠️
note/note_verifier.go 79.10% 10 Missing and 4 partials ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##              main      #66       +/-   ##
============================================
- Coverage   100.00%   81.73%   -18.27%     
============================================
  Files            3        5        +2     
  Lines           55      230      +175     
============================================
+ Hits            55      188      +133     
- Misses           0       30       +30     
- Partials         0       12       +12

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

roger2hk
roger2hk approved these changes Dec 5, 2023
View reviewed changes

@roger2hk roger2hk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM assuming this is a direct copy from transparency-dev/witness/internal/note. Found some minor difference in note/note_verifier.go and note_verifier_test.go.

@AlCutter

AlCutter commented Dec 5, 2023

Copy link
Copy Markdown
Collaborator Author

LGTM assuming this is a direct copy from transparency-dev/witness/internal/note. Found some minor difference in note/note_verifier.go and note_verifier_test.go.

I've changed the NewVerifier c'tor slightly as I don't think we need the extra param.

@AlCutter

AlCutter commented Dec 5, 2023

Copy link
Copy Markdown
Collaborator Author

(@roger2hk sorry, will need another LTGM since I added another commit)

@AlCutter
AlCutter merged commit 949529e into transparency-dev:main Dec 5, 2023
@AlCutter
AlCutter deleted the migrate_signers branch December 5, 2023 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@roger2hk roger2hk roger2hk approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@AlCutter @roger2hk