Repository navigation
Add dns_name recommendations for the Origin - #25
Merged
Merged
Conversation
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #25 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 3 3
Lines 57 57
=========================================
Hits 57 57 ☔ View full report in Codecov by Sentry. |
mhutchinson
reviewed
Apr 27, 2023
| The exact format of this is left undefined, but best practice is to have a scheme-less URI-like | ||
| prefix that will be globally unique, and give some idea of the log location/operator, | ||
| e.g. `example.com/log42`. | ||
| The exact format of this is left undefined, but best practice is to use a URI-like strucutre like |
Contributor
There was a problem hiding this comment.
Suggested change
| The exact format of this is left undefined, but best practice is to use a URI-like strucutre like | |
| The exact format of this is left undefined, but best practice is to use a URI-like structure like |
mhutchinson
reviewed
Apr 27, 2023
mhutchinson
reviewed
Apr 27, 2023
Co-authored-by: Martin Hutchinson <mhutchinson@gmail.com>
Hayden-IO
reviewed
Apr 27, 2023
| The exact format of this is left undefined, but best practice is to have a scheme-less URI-like | ||
| prefix that will be globally unique, and give some idea of the log location/operator, | ||
| e.g. `example.com/log42`. | ||
| The exact format of this is left undefined, but best practice is to use a URI-like strucutre like |
Contributor
There was a problem hiding this comment.
Could you use https://www.ietf.org/rfc/rfc2119.txt language, like "The format SHOULD be a URI-like structure. Clients MUST NOT assume that the origin is a URI"?
AlCutter
reviewed
May 2, 2023
| This structure reduces the likelihood of origin collision, | ||
| and gives clues to humans about the log operator and what is in the log. The suffix is optional | ||
| and can be anything. It is used to disambiguate logs owned under the same prefix. | ||
| The format SHOULD be a URI-like strucutre like `<dns_name>[/<suffix>]`, where the log operator |
Collaborator
There was a problem hiding this comment.
Were you working on an old commit? The "strucuture" typo and "With a globally unique..." line below came back :)
AlCutter
approved these changes
May 9, 2023
AlCutter
approved these changes
May 9, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #22 for further context.