Repository navigation
Add support for native CosignatureV1 (alg 0x04) verifier keys - #216
Merged
AlCutter merged 1 commit intoOct 17, 2025
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #216 +/- ##
===========================================
- Coverage 82.57% 70.96% -11.61%
===========================================
Files 5 6 +1
Lines 241 496 +255
===========================================
+ Hits 199 352 +153
- Misses 30 101 +71
- Partials 12 43 +31 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
phbnf
approved these changes
Oct 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR enables the creation and use of
CosignatureV1(algo 0x04) vkeys.These vkeys are "just" algo 0x01 vkeys with a different algo ID.
While they're mechanically convertible between the two types, we're now seeing algo 0x04 vkeys turning up in the wild, so we need to be able to support these "native" cosiger vkeys too.