Repository navigation
Bump golangci lint - #183
Merged
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #183 +/- ##
==========================================
- Coverage 82.57% 75.00% -7.58%
==========================================
Files 5 6 +1
Lines 241 436 +195
==========================================
+ Hits 199 327 +128
- Misses 30 78 +48
- Partials 12 31 +19 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
roger2hk
approved these changes
Mar 31, 2025
roger2hk
reviewed
Mar 31, 2025
Comment on lines
+12
to
+24
| exclusions: | ||
| generated: lax | ||
| paths: | ||
| - third_party$ | ||
| - builtin$ | ||
| - examples$ | ||
| formatters: | ||
| exclusions: | ||
| generated: lax | ||
| paths: | ||
| - third_party$ | ||
| - builtin$ | ||
| - examples$ |
Contributor
There was a problem hiding this comment.
These paths don't exist in this repo.
Collaborator
Author
There was a problem hiding this comment.
I imagine it's just being explicit about defaults (or attempting to preserve defaults from earlier version?)
Collaborator
Author
|
@roger2hk need another approve due to pushing the commit to remove the paths :/ |
roger2hk
approved these changes
Apr 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR bumps
golangci-lint@v2and migrates the config file.Should unblock #182.