Fix annotate() group handling with facets - #6904
Merged
Merged
Conversation
teunbrand
approved these changes
Oct 2, 2026
teunbrand
left a comment
Collaborator
There was a problem hiding this comment.
Great, this looks good to me. I simplified somewhat. Thanks for the contribution!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6862.
annotate()passedgroupthrough as a fixed layer parameter, so it never became a column of the layer data. When a facet repeats that data across panels,groupno longer matches the number of rows andcheck_aesthetics()errors.Following teunbrand's suggestion in the issue,
groupnow goes into thepositionlist withx/yso it ends up in the data and is mapped like the others. It also has to be dropped from the remaining parameters, otherwise the fixedgroupstill overrides the mapped one.annotation_borders()passesgroupthroughannotate(), soannotation_borders(...) + facet_wrap(...)works now as well.I haven't touched #6883 (the
layoutaesthetic); it looks like a separate problem, so I left it for its own fix.