Repository navigation
Bump GitHub Actions off the Node 20 runtime - #1
Merged
Merged
Conversation
Every run warned that checkout/setup-node/cache/upload-artifact target Node 20 and are being forced onto Node 24. Pinned to current majors: checkout v7, setup-node v7, cache v6, upload-artifact v7, download-artifact v8. setup-node started caching package managers automatically in v5, so package-manager-cache is explicitly off — there are no dependencies and no lockfile here, and the auto-cache would only fail looking for one. The release workflow only runs on a v* tag, so tmp-artifact-check.yml mirrors its upload/download path handling to prove the artifact round-trip under the new versions. It is deleted in the next commit. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
It did its job: under upload-artifact@v7 + download-artifact@v8 the
artifact still lands as uxp/mac/{x64,arm64}/syncitol.uxpaddon, which is
the layout build-ccx.js expects.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every workflow run has been warning that
actions/checkout,actions/setup-node,actions/cacheandactions/upload-artifacttarget Node 20 and are being force-run on Node 24. Pinned to current majors:actions/checkoutactions/setup-nodeactions/cacheactions/upload-artifactactions/download-artifactBuild logic, the tag-matches-manifest gate and the CI Node matrix (20/22/24) are untouched.
Breaking changes checked, not assumed
setup-nodev5 began caching package managers automatically. There is no lockfile and there are no dependencies here, so the auto-cache would only fail looking for one —package-manager-cache: falseis now set explicitly in both workflows.download-artifactv5's path change applies to downloads by ID (artifact-ids); this repo downloads by name, so it is unaffected. v8 makes a digest mismatch a hard error rather than a warning, which is what we want for a package that carries a native binary.upload-artifactv5→v7 does not change path handling. The common-ancestor stripping thatuxp-release.ymlrelies on still applies; v7'sarchive: falseis opt-in and unused.checkoutv7 blocks checking out fork PRs forpull_request_target/workflow_run; this repo uses neither.Verification
uxp-release.ymlonly runs on av*tag, so a PR cannot exercise it.tmp-artifact-check.ymlmirrors its upload/download path handling exactly — samepath:block, samepath: uxp/macrestore, samedefaults.run.working-directory— and asserts the layoutbuild-ccx.jsexpects. That temp workflow is deleted before merge; it exists only so the artifact round-trip is proven rather than reasoned about.🤖 Generated with Claude Code