Drop the gcloud emulator test against an unavailable image - #1464
Conversation
The Datastore and Firestore emulator tests each ran twice, once against the pinned image and once against google-cloud-cli:468.0.0-emulators, to check the module still worked on an older CLI release. Google has since pruned every 468.x tag from gcr.io, so that case fails on a 404 and takes both jobs with it. The oldest -emulators tag still published is 539.0.0, and that floor keeps rising as older tags are pruned, so pinning another old tag only defers the same breakage. The extra case also covered nothing the default one does not: these containers only run "gcloud beta emulators firestore start" with a couple of flags and wait on a log line.
✅ Deploy Preview for testcontainers-node ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Understand this PR’s impact Explore downstream dependencies and potential security impact with Blast Radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 8 included reviews per hour; 6 remain after this review. Summary by CodeRabbit
WalkthroughThe Datastore and Firestore emulator tests now run only against the default ChangesEmulator test coverage
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~5 minutes Change: Bug fix 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Warning Some tools did not complete. Review the errors below. 🔧 ESLint
packages/modules/gcloud/src/datastore-emulator-container.test.tsESLint skipped: missing config or dependency (missing-dependency). The ESLint configuration references a package that is not available in the sandbox. packages/modules/gcloud/src/firestore-emulator-container.test.tsESLint skipped: the matched ESLint configuration already failed (missing-dependency). Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. A rabbit checks the default image bright Comment |
Problem
The Datastore and Firestore emulator tests each ran twice through
it.each, once against the pinned image and once against a hardcodedgoogle-cloud-cli:468.0.0-emulators, to check the module still worked on an older CLI release.Google has since pruned every
468.xtag from gcr.io, so that case fails:Four of the eight
Tests (gcloud, ...)jobs fail on this today, on every open PR.Fix
Drop the second case and keep the default-image one.
Pinning a different old tag would only defer the problem. The oldest
-emulatorstag still published is539.0.0, and that floor rises as Google keeps pruning, so the test would break again on its own schedule.The removed case also covered nothing the remaining one does not. These containers are thin wrappers that run
gcloud beta emulators firestore startwith a couple of flags and wait on a log line. An image nobody can pull is not a compatibility guarantee.The
468.0.0tag appears nowhere in the docs, so no documented example changes. The surviving test keeps thedatastoreExampleandfirestoreExampledoc blocks intact, and is renamed toshould work using default versionto match the sibling PubSub and BigQuery tests.Verification
Both tests pass locally, and the module typechecks and lints clean.