Bump testcontainers/sshd image from 1.3.0 to 1.4.0 - #1364
Merged
Merged
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b4edc7029d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
✅ Deploy Preview for testcontainers-node ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Member
Author
|
Fixed in the follow-up commit — |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps the default
testcontainers/sshdimage from1.3.0to1.4.0inpackages/testcontainers/src/port-forwarder/port-forwarder.ts.What's new in 1.4.0:
AddressFamily anyadded to the sshd config (fixes SSH connections on dual-stack hosts)Verification:
Tests found:
packages/testcontainers/src/port-forwarder/port-forwarder.test.ts(3 tests)packages/testcontainers/src/port-forwarder/port-forwarder-reuse.test.ts(2 tests)Tests were run locally. All 5 failed due to sandbox networking constraints (
host.testcontainers.internalunreachable from inside containers in the local environment) — the same failures occur with1.3.0viaSSHD_CONTAINER_IMAGE=testcontainers/sshd:1.3.0. Thetestcontainers/sshd:1.4.0image was confirmed available on Docker Hub and was successfully pulled during test runs.Not a breaking change — only the default image tag is updated; users can still override via
SSHD_CONTAINER_IMAGE.