Sitelet https://github.com/testcontainers/testcontainers-node/pull/1357
Skip to content

Copy Redpanda runtime assets during build - #1357

Merged
cristianrgreco merged 2 commits into
mainfrom
codex/fix-redpanda-build-assets
Jun 6, 2026
Merged

cristianrgreco merged 2 commits into
mainfrom
codex/fix-redpanda-build-assets

Conversation

@cristianrgreco

Copy link
Copy Markdown
Collaborator

Summary

  • copy Redpanda runtime assets during postbuild so normal workspace builds produce usable output
  • keep prepack focused on package metadata files
  • document that runtime assets required by compiled code must be copied during the normal build lifecycle

Verification

  • npm run build --ignore-scripts --workspace packages/testcontainers -- --project tsconfig.json
  • npm run build --ignore-scripts --workspace packages/modules/redpanda -- --project tsconfig.json --noEmit
  • npm run build --workspace packages/modules/redpanda
  • npm_config_cache=/private/tmp/testcontainers-node-npm-cache npm pack --dry-run --json --workspace @testcontainers/redpanda
  • npm test -- packages/modules/redpanda/src/redpanda-container.test.ts
  • npm run format
  • npm run lint
  • npm run check-compiles
  • git diff --check

Test results

  • Red: a normal Redpanda workspace build left build/assets absent before this change.
  • Green: a normal Redpanda workspace build now creates build/assets/bootstrap.yaml and build/assets/redpanda.yaml.hbs.
  • Green: the compile-only invocation keeps CI-provided flags attached to tsc and does not run postbuild.
  • Green: the dry-run package archive includes both runtime assets.
  • Green: the focused Redpanda suite passed (4 passed).

Compatibility

This is a backward-compatible bug fix. The public API is unchanged. Published packages retain the same runtime assets, while local workspace builds now produce the complete runtime output without relying on prepack.

@netlify

netlify Bot commented Jun 1, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for testcontainers-node ready!

Name Link
🔨 Latest commit c1a74b3
🔍 Latest deploy log https://app.netlify.com/projects/testcontainers-node/deploys/6a23d94418dee000089e4b2f
😎 Deploy Preview https://deploy-preview-1357--testcontainers-node.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@cristianrgreco cristianrgreco added bug Something isn't working patch Backward compatible bug fix labels Jun 1, 2026 — with ChatGPT Codex Connector
Clarify build lifecycle requirements for runtime assets and testing practices.
@cristianrgreco
cristianrgreco merged commit 7c1ca77 into main Jun 6, 2026
16 checks passed
@cristianrgreco
cristianrgreco deleted the codex/fix-redpanda-build-assets branch June 6, 2026 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working patch Backward compatible bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant