Repository navigation
Rename env vars TEMPORAL_CLI.. to TEMPORAL.. - #239
Merged
Merged
Conversation
samanbarghi
approved these changes
May 12, 2023
Contributor
|
@feedmeapples Are you aware of any follow up action to update the doc too? |
Member
|
@feedmeapples we need to revert this change, it broke the usage in admintools. We rely on these env vars in too many samples. |
|
This has broken the CLI in admin-tools/1.21.1. Need to export variables without CLI in VarName as a workaround. |
|
@bergundy @feedmeapples : Is there any plan to revert the env var names back to contain "cli" in future ? |
Member
|
No, we’re staying with this new convention. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
renamed env variables
Why?
Consistency of env names. Shorter in --help output
Checklist
Closes
How was this tested: