Add persistence info to start-dev banner - #1033
Conversation
|
A few suggestions on the banner format:
Suggested output: And for file-backed: |
|
Please make sure you have signed the Temporal CLA before this can be merged. |
|
Applied all four banner suggestions in 2b09ade: |
Signed-off-by: Sai Asish Y <say.apm35@gmail.com>
Signed-off-by: Sai Asish Y <say.apm35@gmail.com>
|
@SAY-5 you have to sign the CLA, I can't merge this until you do. Let me know if you are having problem with it. |
Related issuesCloses #634 What changed?
ChecklistStability
Design
Help text (see style guide at the top of
Behavior
Tests
Manual testsSetup Happy path -- in-memory Happy path -- file-backed |
…#1104) ## Summary Backports server-independent changes from `main` into `release/1.8.x`. Every commit here was verified to build and pass codegen against the release line's current dependency pins (`server v1.31.0`, `sdk v1.41.1`, `api v1.62.8`) — nothing pulls in the newer server/SDK/API that landed on `main` via #1017. Scope agreed as: bug fixes + CLI changes + CI/tooling. Dependency bumps (#1040, #1052, #1063) and server-version-dependent features are intentionally excluded. ## Included (22 commits, cherry-picked with `-x`) **CLI / bug fixes** - #1006 Fix help with value flags (addresses #1003 — `--help` with value flags like `--address 123` surfaced `pflag: help requested` as an error) - #1012 skip CountWorkflow in batch operations when `--yes` is set - #1016 Sort output of listing search attributes - #1029 Workflow delete now prompts for confirmation - #1033 Add persistence info to start-dev banner - #1047 Add `temporal schedule list-matching-times` command - #1056 Fix task-queue config set help: use real fairness weight flag names - #1059 Prefix dev server cluster ID with `dev-server-` - #1089 fix: tls is not added for profiles without tls - #1099 Clarify activity pause timeout behavior - #941 auto-generate deprecation warnings from YAML config **Tests** - #1005 Fix flakey test by disabling EC2 metadata lookup - #1020 Remove `time.Sleep()` in commands.taskqueue_test.go **CI / tooling** - #1015 pin alpine docker image to 3.23.4 - #1024 remediate missing-dependency-cooldown - #1034 Bump actions/upload-artifact from 4 to 7 - #1044 improve dependabot config - #1045 add PR template - #1054 pin and bump GitHub Actions to latest versions - #1057 use allow instead of ignore for dependency-type in dependabot config - #1080 Bump the github-actions group with 2 updates ## Excluded (rely on the new server/SDK version) #1017 (server bump v1.31.0 -> v1.32.0-157.0), #1046, #1087, #1001, #1091, #1084 ## Verification - `go build ./...` passes - all test packages compile - `make gen` reports no codegen drift - server/sdk/api pins unchanged from `release/1.8.x` ## CI endpoint fix (added) Also backports the API-key CI test endpoint change from #1087 (`us-east-1` -> `ca-central-1`) as a standalone CI-only commit. This resolves the `Request unauthorized` failure in the "Test cloud API key" steps on `release/1.8.x`. The rest of #1087 (Nexus Operation command code) is excluded as it depends on the new server version. --------- Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Sai Asish Y <say.apm35@gmail.com> Co-authored-by: Kevin Woo <3469532+kevinawoo@users.noreply.github.com> Co-authored-by: Rodrigo Zhou <rodrigo.zhou@temporal.io> Co-authored-by: Stephan Behnke <stephanos@users.noreply.github.com> Co-authored-by: Jiechen Zhong <jiechen.zhong@temporal.io> Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com> Co-authored-by: Kent Gruber <kent.gruber@temporal.io> Co-authored-by: picatz <14850816+picatz@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: John Votta <jpvotta@gmail.com> Co-authored-by: Nasit Sarwar Sony <nasitsony96@gmail.com> Co-authored-by: hussam-salah <156124396+hussam-salah@users.noreply.github.com> Co-authored-by: Sai Asish Y <say.apm35@gmail.com> Co-authored-by: Bitalizer <23104115+bitalizer@users.noreply.github.com> Co-authored-by: Sean Kane <spkane31@gmail.com> Co-authored-by: Jessica Laughlin <JLDLaughlin@users.noreply.github.com>
temporal 1.8.0 Created-by: HarmonybrewBot Commit-by: HarmonybrewBot Merged-by: HarmonybrewBot Description: Created by `brew bump` --- Created with `brew bump-formula-pr`.<details> <summary>release notes</summary> <pre>## New Features ### `temporal schedule list-matching-times` New command that lists the next matching start times for a schedule, making it easier to preview when a schedule will fire. ([#1047](temporalio/cli#1047)) ## Improvements - **Persistence info in the dev server banner** — `temporal server start-dev` now reports its persistence configuration in the startup banner. ([#1033](temporalio/cli#1033)) - **Dev server cluster ID is now prefixed with `dev-server-`** ([#1059](temporalio/cli#1059)) - **Search attributes are now sorted** — the output of listing search attributes is sorted for stable, readable output. ([#1016](temporalio/cli#1016)) - **`temporal workflow delete` now prompts for confirmation** before deleting. ([#1029](temporalio/cli#1029)) - **Batch operations skip the pre-count when `--yes` is set** — `CountWorkflow` is no longer called for batch operations run with `--yes`. ([#1012](temporalio/cli#1012)) - **Clearer activity pause help** — clarified the timeout behavior described in `activity pause` help text. ([#1099](temporalio/cli#1099)) - **Correct fairness weight flag names in help** — `task-queue config set` help now shows the real fairness weight flag names. ([#1056](temporalio/cli#1056)) ## Bug Fixes - **`--help` no longer errors when combined with value flags** — passing `--help` alongside a value flag (e.g. `--address 123 --help`) previously surfaced `pflag: help requested` as an error. ([#1006](temporalio/cli#1006), addresses [#1003](temporalio/cli#1003)) - **TLS now applied for profiles without an explicit TLS block** — profiles that omitted a `tls` section were not getting TLS enabled. ([#1089](temporalio/cli#1089)) - **Extension delegation preserves exit codes** — when `temporal` delegates to an extension, it now exits with the same exit code the extension returned. ([#1116](temporalio/cli#1116)) - **Docs generation escapes MDX-incompatible patterns** — `gen-docs` now escapes MDX-incompatible content and supports a `-subdir` flag, fixing documentation builds. ([#1112](temporalio/cli#1112)) ## Dependency Upgrades - UI Server: upgraded to v2.50.1 - Temporal Server: v1.31.2 - Go: v1.26.4 - Pinned Alpine base image and bumped GitHub Actions dependencies (CI/tooling only) ## What's Changed * chore: backport server-independent changes from main to release/1.8.x by @chaptersix in temporalio/cli#1104 * Backport to 1.8.x: Add option to disable newsfeed in UI (#1109, #1110) by @chaptersix in temporalio/cli#1111 * Backport to 1.8.x: MDX docs fixes, server v1.31.2, extension exit code (#1112, #1115, #1116) by @chaptersix in temporalio/cli#1118 **Full Changelog**: temporalio/cli@v1.7.3...v1.8.0 </pre> <p>View the full release notes at <a href="/sitelet?url=https%3A%2F%2Fgithub.com%2Ftemporalio%2Fcli%2Fpull%2F%253Ca%2520href%3D"https://github.com/temporalio/cli/releases/tag/v1.8.0">https://github.com/temporalio/cli/releases/tag/v1.8.0</a>.</p">https://github.com/temporalio/cli/releases/tag/v1.8.0">https://github.com/temporalio/cli/releases/tag/v1.8.0</a>.</p> </details> <hr> See merge request: Harmonybrew/homebrew-core!14039
What was changed
temporal server start-devnow prints aPersistence:line at the end of the startup banner.In-memory (no
--db-filename):File-backed:
Why?
Per #634, the start-dev banner did not surface what form of persistence the dev server uses, so users could not tell at a glance whether Workflow Executions would survive a restart.
Checklist
Closes [Feature Request] Add persistence information to
start-devbanner #634How was this tested:
Two new tests in
internal/temporalcli/commands.server_test.gostart the dev server, capture stdout, and assert that the banner containsPersistence:plus the expected backend description. Both pass locally and fail when the banner change is reverted.