Conversation
|
FYI, I tested the latest commit in a personal project and it worked nicely. |
|
@borchero , could you rebase this |
|
@jayvdb sorry for the delay, finally done 😄 |
|
ping @knyar & @patrickod & @willnorris |
|
bump, just in case |
|
I'm not really sure what to do to link an already present binary on Windows -- do I need to do anything if it's on the path? |
|
@borchero Apologies, the GitHub action has since migrated to a JavaScript implementation. If you're willing to submit a new PR against that, we'll review it. One thing I would recommend changing is to just allow specifying the path to the binaries directly as parameters to the action, that way it doesn't matter if they're on the PATH or not. So instead of a |
Motivation
Potentially,
tailscale(d?)have been installed via a separate workflow step to manage the Tailscale version via an external tool (e.g. viaconda-forge- tailscale, tailscaled). This change allowstailscale/github-actionaction to simply use these installed binaries rather than forcing the user to download additional binaries.