fix(gui): improve header and button color contrast (fixes #10488) - #10815
Open
giri256 wants to merge 1 commit into
Open
fix(gui): improve header and button color contrast (fixes #10488)#10815giri256 wants to merge 1 commit into
giri256 wants to merge 1 commit into
Conversation
Signed-off-by: Giridhar <giridharpavan593@gmail.com>
Member
|
Can you post some screenshots showing the difference? |
Author
|
Thanks — here are before/after screenshots rendered with the exact Bootstrap and theme CSS from upstream Default theme
The bright success/warning/danger surfaces switch from white text to black text; the danger action also uses the darker red background. Dark theme
The semantic backgrounds become darker and consistently use white text. The black theme uses the same updated semantic color rules as the dark theme. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Improve the contrast of semantic request-dialog headers and buttons in the light, dark, and black GUI themes.
The light theme keeps its bright semantic colors and uses black text for success, warning, and danger alerts plus success/warning buttons. Danger buttons use the existing darker red with white text. The dark themes use darker success, warning, and danger backgrounds with white text.
The lowest enabled-state contrast ratio is 4.509:1, meeting WCAG AA for normal text.
Testing
go run build.go assetsgo run build.go build syncthinggit diff --checkScreenshots
Rendered light and dark fixtures locally to verify the complete alert and button combinations. The computed colors matched the intended theme rules and no clipping or layout changes were introduced.
Documentation
No documentation changes are required; this only corrects existing theme colors.