feat: add loading skeleton for flashcard grid - #98
Open
ohlexolaoluwa wants to merge 1 commit into
Open
Conversation
Replaces the spinner with a skeleton loading UI on the flashcard list in StudySetDetailPage for better perceived performance and UX during loading. Adds a reusable Skeleton primitive (components/ui/skeleton.tsx) following the existing Spinner component pattern, plus a FlashcardListSkeleton that mirrors the FlashcardItem card layout. Closes studyield#37
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the loading spinner with a skeleton UI for the flashcard list, per #37.
Skeletonprimitive incomponents/ui/skeleton.tsx, following the existingSpinnercomponent patternFlashcardListSkeleton, styled to match the existingFlashcardItemcard layoutStudySetDetailPage.tsxduringflashcardsLoadingNote: I wasn't able to run this against a live backend locally since it requires Postgres/Redis/Qdrant/ClickHouse — happy to make adjustments if anything looks off visually once reviewed.
Closes #37