Stop FindHeaderSection spinning forever on a file with no header - #485
Open
attixray wants to merge 1 commit into
Open
Stop FindHeaderSection spinning forever on a file with no header#485attixray wants to merge 1 commit into
attixray wants to merge 1 commit into
Conversation
getline(buf, BUFSIZ, ';') on a stream whose next BUFSIZ bytes contain no semicolon sets failbit and leaves buf unchanged. The scan loop only tests eof(), which never arrives once failbit is set, so it never terminates - hand it any binary file and it hangs instead of reporting that the file is not STEP. Treat a failed extraction the same as end of file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
STEPfile::FindHeaderSection()loops onin.getline( buf, BUFSIZ, ';' )looking forHEADER, and exits only viaeof(). A file with no;in its firstBUFSIZbytes — a binary file handed to the reader by mistake, say — setsfailbitand leavesbufunchanged.getlinethen does nothing on every subsequent call,eof()never becomes true, and the loop spins forever on a single-character diet.Check
fail(), report it as an input error, and return.